Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.42k stars 1.99k forks source link

Private Site Videos URLs Break in Safari #31859

Closed azollafox closed 2 years ago

azollafox commented 5 years ago

Steps to reproduce

  1. Have a simple WordPress.com site with a Premium or Business plan that's set to private
  2. Upload a mp4 file
  3. Grab the url for the video and paste it into Safari

What I expected

The video would play as it does in any other browser

What happened instead

An error screen shows. This goes away if the site is made public

broken videos in safari

(Image link: https://cld.wthms.co/vEKosx )

Browser / OS version

MacOS Mojave 10.14.3 Safari Version 12.0.3 (14606.4.5)

User reported there's also a problem on iPhones, but I haven't been able to test yet as I have Android. @senff did some testing with me on this in the #tickets Slack channel but reported that he couldn't get it to open and keep him logged in

I log in, then I go to that MP4 and it says I'm not logged in

Context / Source

The user reported it in #1916549-zen and I was able to reproduce along with @senff . I was able to reproduce this on my own test site with a video. When the site is set to private the video does not play on Safari. When I switch to public it's fine. I'm wondering if it's related to this other issue with the media library and private simple sites https://github.com/Automattic/wp-calypso/issues/25115 or to the new Safari privacy features.

user-report

samjhamdy commented 5 years ago

Also reported in #2443578-zen. User is not seeing header video playing on Private site in Safari.

github-actions[bot] commented 3 years ago

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

cpapazoglou commented 3 years ago

This issue is still present.

I get an error in Safari Failed to load resource: Plug-in handled load. This happens with all Videos served directly from a private P2. I also get an error even in Chrome when trying to edit a video in media library of Calypso. I am not sure if these are related though.

Access to XMLHttpRequest at 'https://public-api.wordpress.com/rest/v1.1/videos/3xFfnR7f/playlist/dvd-master' from origin 'abrRw-p2' has been blocked by CORS policy: The value of the 'Access-Control-Allow-Origin' header in the response must not be the wildcard '*' when the request's credentials mode is 'include'. The credentials mode of requests initiated by the XMLHttpRequest is controlled by the withCredentials attribute.
VM1567 videopress-routes.min.js:2 GET https://public-api.wordpress.com/rest/v1.1/videos/3xFfnR7f/playlist/dvd-master net::ERR_FAILED=

VM1567 videopress-routes.min.js:2 VIDEOJS: ERROR: (CODE:4 MEDIA_ERR_SRC_NOT_SUPPORTED) The media could not be loaded, either because the server or network failed or because the format is not supported. Et {code: 4, message: "The media could not be loaded, either because the …rk failed or because the format is not supported."}

Workaround: Adding the video with a video block, eventually uses video.wordpress.com which works as expected.

Related convo: pd8D2H-3j-p2#comment-20

github-actions[bot] commented 2 years ago

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

cuemarie commented 2 years ago

📌 SCRUBBING : RESULT

📌 FINDINGS/SCREENSHOTS/VIDEO

Example

Markup on 2022-10-04 at 10:50:41

📌 ACTIONS

github-actions[bot] commented 2 years ago

Support References

This comment is automatically generated. Please do not edit it.