Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.39k stars 1.98k forks source link

Adding Canva oEmbed to WordPress.com #32928

Open richardmtl opened 5 years ago

richardmtl commented 5 years ago

Requested by a representative from Canva in 1967362-zen

How many active monthly users does your service have?

At the moment Canva has over 15 million monthly active users.

Do you have a WordPress.org plugin?

No.

How many self-hosted WordPress sites currently embed your service?

Canva designs are embedded and viewed as embeds several thousand times every day. We do not keep track of how many of them are embedded on self-hosted WordPress sites.

Does your service already support oEmbed?

Yes.

What are the URL scheme and oEmbed API endpoint for your service?

oEmbed API endpoint: https://www.canva.com/_oembed URL scheme: https://www.canva.com/design/*/view

What is an example valid URL that we can use to test embedding your service?

https://www.canva.com/design/DADXXpPldJk/view

stale[bot] commented 4 years ago

This issue has been marked as stale and will be closed in seven days. This happened because:

You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation.

happychait commented 3 years ago

In #11371224-hc a customer reported that links within their Canva embed are working on desktops, but not on mobiles.

I tested and found that's the case with their embed: https://www.canva.com/design/DAENPzuSn5s/view

The embed itself works, but not the links added to the Canva embed.

github-actions[bot] commented 2 years ago

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

katiebethbrown commented 9 months ago

There is a trac ticket for getting this added in core: https://core.trac.wordpress.org/ticket/58840

github-actions[bot] commented 9 months ago

Support References

This comment is automatically generated. Please do not edit it.

Robertght commented 8 months ago

Canva seems to be working already on WordPress.com, but it's not working well with the longer presentations.

Example: https://www.canva.com/design/DAFbtrqjeCg/view

After page 40 or so, images stop loading.

katiebethbrown commented 8 months ago

Canva seems to be working already on WordPress.com, but it's not working well with the longer presentations.

@robertght - I’m not seeing it work on my end. I’m working on a Team51 partner site, and we’re getting a Sorry, this content could not be embedded message on a WPcom atomic site.

Canva URL that isn’t working: https://www.canva.com/design/DAFs8Xgn4K0/view

image

When I try the same URL on my WPcom simple test site it automatically switches away from the embed block to a paragraph block with the URL.

EDIT: Interestingly, the URL you shared does work though. So there may be something disparate between the two. The Trac ticket mentions the location of the meta tag being an issue.

oEmbed discovery does not work for Canva because the meta tag is very far down in the page source and WP only parses the first few KB of the response.

Maybe the tag is higher up in the file you’re using the one compared to the one we tried?

Robertght commented 8 months ago

Maybe the tag is higher up in the file you’re using the one compared to the one we tried?

That could very well be, but I have not yet tried it.

I'm also pinging @cuemarie in case we can get more eyes on it.

cuemarie commented 8 months ago

Given the trac issue shared above, and Canva not being something explicitly supported by Gutenberg's embed blocks, this does seem like it would need a core fix. But I've added it to the One Board so it's something our teams are aware of as a feature request for Dotcom as well.

📌 ACTIONS