Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.41k stars 1.99k forks source link

Signup: no option to log in with existing username for non-EN users #3433

Closed jenial closed 8 years ago

jenial commented 8 years ago

URL:

https://wordpress.com/start/upgrade/user

Issue Description

During signup process, if a user enters an already existing username, the English version shows this error message: Sorry, that username already exists! If this is you log in now.

For non-English, a partial error message is shown: only the translated version of Sorry, that username already exists! (no option to log in for existing users).

Confirmed the issue in DE, FR, ID, NL, RU locales. Likely a global issue for all non-EN locales.

Browser / OS version

Google Chrome 48.0.2564.109 (64-bit) OS X El Capitan 10.11.3

Screenshots

English en_desktop_4b_account_validation_invalid_screenshot1453773513950

French fr_desktop_4b_account_validation_invalid_screenshot1453773931548

lancewillett commented 8 years ago

Confirmed this is still broken, testing the signup flow in Spanish:

screen shot 2016-05-03 at 1 45 20 pm

Missing the link and text.

lancewillett commented 8 years ago

The translated text is saved correctly in GlotPress: https://translate.wordpress.com/projects/wpcom/es/default/?filters%5Bterm%5D=If+this+is+you&filters%5Buser_login%5D=&filters%5Bstatus%5D=either&filters%5Bview%5D=&filter=Filter&sort%5Bby%5D=priority&sort%5Bhow%5D=desc

screen shot 2016-05-03 at 1 48 33 pm

lancewillett commented 8 years ago

Code ref: https://github.com/Automattic/wp-calypso/blob/9cb2557484fc059ab3af01be5de03e913770abf1/client/components/signup-form/index.jsx#L293 — looks properly coded with the translate call.

bisko commented 8 years ago

This requires an API change, tracked on D1793-code. It should work automagically after the fix is released.

bisko commented 8 years ago

The change is live and the issue should not be occurring anymore. @lancewillett Can you verify that?

lancewillett commented 8 years ago

Confirmed worked as expected! Nice.

screen shot 2016-05-13 at 10 13 34 am