search

Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.42k stars 1.99k forks source link

Footer credits changed via Customizer "Site Identity" options will not update #35968

Closed mrfoxtalbot closed 3 months ago

mrfoxtalbot commented 5 years ago

Steps to replicate

  1. Go to My Site > Design > Customize https://wordpress.com/customize
  2. Select "Site Identity" and change the Footer credit options:

I tested this with Modern Business and Twentynineteen

Result

The footer will not update

Expected

Footer credits should change accordingly

geekinthegirl commented 5 years ago

Another instance of this here: #15531608-hc

User changed their Footer Credit option to 'Hide', with no effect.

chiape commented 5 years ago

Hey there, we've just found a similar issue here and it only happens when changing the language to EN-gb.

Affected themes:

Also, instead of changing accordingly the link redirect to WordPress.org

desnum commented 4 years ago

Hi there,

I have another case in the Redhill theme, where "Hide" doesn't work to remove the footer credit only when the language is set to EN-gb.

zen-2523410

zdenys commented 4 years ago

Another case here 2572085-zen with Sophisticated Business Theme. But it seems that it affects many (if not all) themes and depends specifically on en-gb language being selected in ~https://wordpress.com/me/account~ https://wordpress.com/settings/general/

Possibly it affects any other non-English languages too as in https://github.com/Automattic/themes/issues/1222

kwight commented 4 years ago

I was hoping this might be a quick fix, but I've been unable to replicate. I tried in WP Admin and WP.com customizers, with en-gb and fr-ca languages, on both free and Premium plans. (I did notice that translations of the footer are not working in fr-ca, but I assume that's unrelated.)

Any other tips or indications for reproducing?

zdenys commented 4 years ago

I realized that in my previous comment I incorrectly indicated where en-gb should be set. It's in https://wordpress.com/settings/general/ (so for the site itself) and not in https://wordpress.com/me/account.

I can reproduce with Barnsbury, Dalston, Maywood, Mayland, Shawburn, Alves, Exford, Stratford, Coutoire, Morden, Stow, Hever, Leven, Brompton, Redhill.

Also reported here https://github.com/Automattic/themes/issues/1424 and here https://github.com/Automattic/themes/issues/1 (additional details here pNEWy-cyw-p2)

kwight commented 4 years ago

The cause is a regex problem, being unable to match on languages with country codes (eg. en-GB, fr-CA). A patch is ready for review in D36982-code.

kwight commented 4 years ago

Fixed in D36982-code.

gwensmithx commented 2 years ago

I'm reopening this issue because I ran into this today. Site is on the Pro Plan. Site Language is in German and even though it's set to hide the footer credit in the customizer, it still shows.

I can replicate this on my test site. I set my site language to German and Spanish and it disregarded the hidden setting in the customizer. Setting the language back to English resolves the issue and the credit is hidden.

https://user-images.githubusercontent.com/5779512/170374358-042b337c-e5ad-4eeb-9172-a6a8b29cfaa1.mp4

upwardmomentum84 commented 2 years ago

Ran into this here: 12976382-hc

Theme is Payton. I was able to replicate the issue on my end on a test site.

github-actions[bot] commented 2 years ago

Support References

This comment is automatically generated. Please do not edit it.

mrfoxtalbot commented 7 months ago

Cross-referencing https://github.com/Automattic/wp-calypso/issues/58798, https://github.com/Automattic/wp-calypso/issues/59363, & https://github.com/Automattic/wp-calypso/issues/81611

mmtr commented 3 months ago

This should have been fixed now by D156044-code (Simple sites) and https://github.com/Automattic/jetpack/pull/38458 (Atomic sites).