search

Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.4k stars 1.98k forks source link

Themes: Card on Uploads page needs space between period and next sentence. #36176

Open sixhours opened 4 years ago

sixhours commented 4 years ago
Screen Shot 2019-09-16 at 12 21 15 PM

1) Start with a Free site 2) Go to Themes 3) Click the Upload Theme button (on the right) 4) Look at the card at the bottom of the page. There should be a space between the period and "Questions?"

danhauk commented 4 years ago

Unrelated to the actual typo, one thing that seems weird to me is the Please clear all issues above... if there are no "issues" listed above. For reference, here's how it looks if there are issues that are labeled as issues:

Screen Shot 2019-10-08 at 11 42 53 AM

In the case of the original screenshot, is the issue to be cleared the fact that you need a business plan? That's a weird way to put it. Can we just remove the second card if there are no issues and keep the callout banner?

image
sixhours commented 4 years ago

Can we just remove the second card if there are no issues and keep the callout banner?

Yep, I flagged that in #33063 and #33069 (happens on both the Themes and Plugins pages). There's a proposed fix for both here, but it's still in progress: #35642

github-actions[bot] commented 3 years ago

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

github-actions[bot] commented 2 years ago

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.