search

Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.4k stars 1.98k forks source link

Sharing: Custom Excerpts not included in Publicize action #38697

Open tmmbecker opened 4 years ago

tmmbecker commented 4 years ago

From 4242-GH-jpop-issues, site is not sharing custom excerpt due to what appears to be a timing issue. The post seems to have been published before we could save meta data to it in the editor (i.e. before an autosave or a manual save as a draft).

Scheduling and resharing work fine as does saving as a draft and then publishing. But creating a post and immediately publishing and sharing prevents the custom excerpt from being included in the share.

We were not able to replicate and this seems, for now, to be specific to one site. They do not have this problem with other sites on the same server.

lancewillett commented 4 years ago

I noticed something similar to this today on my blog, sensible.blog

  1. Drafted a post, saved
  2. I edited the text in “Jetpack” icon tab in editor sidebar
  3. Then I published with the button in the editor (not scheduled)

When I view the post on Twitter and LinkedIn, the custom text I wrote doesn’t appear. Why?

It only shows the title of the post and not my custom excerpt.

lancewillett commented 4 years ago

See also https://github.com/Automattic/wp-calypso/issues/34002

nickpagz commented 4 years ago

I've noticed this as well on a recent blog I just started. My custom twitter message is ignored. Both times I tried this it failed to post the custom message. I can't remember the first instance, but the last one I edited the message then clicked on Publish. I will try again with another post in a few days with a "Save draft", exit the post, re-open, check the custom message is still saved, then try publishing it. Not sure what else to try.

nagpai commented 4 years ago

User report 3065021-zd

Similar issue reported for JP here, but looks like it was not consistently reproduced https://github.com/Automattic/jetpack/issues/11752

Some other WP.com simple sites noted there too.

nagpai commented 4 years ago

Workaround suggested by @marutim

  1. Write the post.
  2. Write the custom message for Twitter.
  3. Hit the "Save draft" and wait for a confirmation message that the draft has been saved.
  4. Hit the "Publish" button only after seeing confirmation that the draft is saved.
supernovia commented 4 years ago

I have a case here. The user is clicking Save Draft prior to publishing, but still doesn't get the custom message each time: https://wordpress.com/forums/topic/twitter-posting-is-busted-with-block-editor/

mrfoxtalbot commented 4 years ago

I have just re-tested this in detail and I can confirm that the custom social media excerpt will not work:

Default Excerpt + Custom Excerpt (default excerpt is shown) https://claragomez.es/2020/07/28/twitter-card-preview-test/ Screen Shot on 2020-07-28 at 11:42:44

No Default Excerpt + Custom Excerpt (post content is shown) https://claragomez.es/2020/07/28/twitter-card-preview-test-no-excerpt/ Screen Shot on 2020-07-28 at 11:43:59

No Default Excerpt + Custom Excerpt + Saved Draft after having entered Custom Excerpt: https://claragomez.es/2020/07/28/twitter-card-preview-test-no-excerpt-saving-as-draft-after-adding-custom-message/ Screen Shot on 2020-07-28 at 11:44:49

Interestingly enough, in this last case the text will be used for the content of the tweet/publication, but not on the Card itself.

I have provided Twitter examples but the same happens on Facebook Cards.

cathymcbride commented 4 years ago

related or possibly duplicate issues:
https://github.com/Automattic/jetpack/issues/11752 https://github.com/Automattic/jetpack/issues/14269 https://github.com/Automattic/wp-calypso/issues/34002 45114-core <-- likely the root issue

davemart-in commented 4 years ago

Thanks for the recap @cathymcbride! It looks like this just came up again in the core patch: 45114-core#comment:25 Until that is fixed, there is not much we can do.

kriskarkoski commented 4 years ago

Another report in #3266692-zen

lizkarkoski commented 4 years ago

Another report that originally came to us on Twitter at #3256787-zen

ChrissiePollock commented 4 years ago

The reporter from #3256787-zen added:

My blog headers are not the specified size for a featured image, and worked perfectly well before the UI started specifying a size for optimal headers. Could this be an issue?

I will be typing my custom text into the Twitter card box and the UI will reload. This happens without fail on every attempt. Could this also be an issue?

They tried posting in Firefox, without extensions, to no avail

*The site is using a retired theme. Would that be a factor?

eduardozulian commented 4 years ago

Another report in #3246138-zen

kylemcph commented 3 years ago

Another report in #3365266-zen. I tested the workaround mentioned by @marutim here and that works for my test site. Asked user to do the same.

geekinthegirl commented 3 years ago

This issue just came up again from #3365266-zen / #25043080-hc, who was a little frustrated with the manual workaround. I've let them know we're still working on this.

cathymcbride commented 3 years ago

@jeherve it looks like the core bug has been fixed with an API update 🎉. Should this come JPs to fix now?

jeherve commented 3 years ago

Should this come JPs to fix now?

We should indeed be able to benefit from the change in https://core.trac.wordpress.org/changeset/49172 , although since Jetpack will support WordPress 5.5 until WP 5.7 comes out, we'll need to handle both versions for a while longer.

I updated both linked Jetpack issues accordingly.

NoHopeRadio commented 3 years ago

Just mentioning another case here: #3732408-zen

mrfoxtalbot commented 3 years ago

Possibly related 3741014-zen

kriskarkoski commented 3 years ago

Potentially another case in 4030166-zen when sharing to LinkedIn

msilbers commented 2 years ago

reported in 34190442-hc

thekingsprojects commented 2 years ago

Another report here: 4810674-zen

Note that user is using the classic editor. I tested on my own site, and while the "save as draft first" workaround does seem to work in the block editor, I was not able to get it to work in the classic editor—the post draft saves, but the custom message is overwritten by the post title/default again. I suggested the workaround to them just in case, but let them know it might not work.

poeticabdul commented 2 years ago

Another report here: 4810674-zen

Note that user is using the classic editor. I tested on my own site, and while the "save as draft first" workaround does seem to work in the block editor, I was not able to get it to work in the classic editor—the post draft saves, but the custom message is overwritten by the post title/default again. I suggested the workaround to them just in case, but let them know it might not work.

Workaround didn't work from feedback from the user