search

Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.39k stars 1.98k forks source link

Portfolio: Loading on Unsupported Site Causes Crash #38815

Open Aurorum opened 4 years ago

Aurorum commented 4 years ago

Steps to reproduce

  1. Starting at the Calypso dashboard of a site that supports Portfolios (/types/jetpack-portfolio/site)
  2. Use the selector to switch to a site that doesn't support portfolios (I think it needs to be a site you've not used in a while - I could only recreate this with some of my older sites)

What I expected

An error, not a crash

Screenshot 2020-01-13 at 19 59 00

What happened instead

Screen crashed.

Screenshot 2020-01-13 at 19 55 06

Browser / OS version

OS X 10.14.6, Chrome 79

Context / Source

Found when just shifting through portfolios whilst creating an unrelated PR.

kriskarkoski commented 4 years ago

I have confirmed this issue is still reproducible. In my testing it's easiest to repro by switching from a site with Portfolios enabled to a private site.

github-actions[bot] commented 3 years ago

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.