Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.42k stars 1.99k forks source link

Settings: add page for Reading Settings #3900

Closed rralian closed 7 years ago

rralian commented 8 years ago

We're missing a couple of settings that sometimes come up... "infinite scroll" and "Posts per page" ". We can also move over "related posts".

Note: these shouldn't be ported over directly, but first we should consider if they can go into Customizer fields first.

apeatling commented 8 years ago

Posts per page in general should be on this settings page.

rralian commented 8 years ago

We didn't get to this in the support iteration... I'm releasing it from the milestone but leaving it as an open item for us to circle back to. Not adding it to the next iteration, but we can prioritize it if/when we want to.

davewhitley commented 7 years ago

In general, we should think about renaming it. Reading was never clear to me, makes me think of Reader.

If we add a new section, I propose we combine SEO, Import, and Export into one tab, Tools.

Posts per page jetpack

I could not find this, can we get a screenshot of the setting?

infinite scroll

Should this be a customizer option, since not all themes have this, and it's disabled if a footer widget is active?

screen shot 2017-01-23 at 3 57 42 pm

Other things that could be moved to a "site display" tab:

lancewillett commented 7 years ago

Noting that some of the Reading settings from wp-admin have moved into Customizer, and we don't need to duplicate it. Such as Static Front Page.

lancewillett commented 7 years ago

Here's a story from @kathrynwp to help illustrate this:

When setting up a new site, I want to decide how many blog posts are displayed on the blog page, and how many portfolio projects are displayed on the portfolio. I can’t find a spot to change those numbers in Calypso, and I don’t know that WP Admin exists, so I have to find the relevant support pages (separate ones for blog and portfolios) and make my way to an interface I’ve never seen before. This leaves me confused about why there are two redundant dashboards, and whether it’s important for me to familiarize myself with the second one — this literally happened when my mom set up her site. Or if I’m not search-savvy, I have to contact support for help finding the settings.

I think we shouldn't add Calypso site settings that duplicate Customizer settings, though. So before adding a Reading setting like Posts per Page we should consider adding that to Customizer — including drafting a proposal for that to be in core WP, as well, not just a WP.com/Jetpack feature.

lancewillett commented 7 years ago

@melchoyce shared this mockup of Posts per Page number setting in Customizer:

https://marvelapp.com/e1a1bd/screen/11733810

kriskarkoski commented 7 years ago

We also need to port (and update) the now incorrectly titled "Logged out users" setting that disables the follow option for both logged-out and logged-in users despite what the text says:

screen shot 2017-02-16 at 5 50 58 pm

It looks like the functionality was updated sometime after the logged-out actionbar with following was launched, but the text was not updated to reflect that it hides both logged-in and logged-out now. We should also either remove the setting from WP Admin or update the title and text to clarify what it does now.

lancewillett commented 7 years ago

Posts per page could also go into Pages -> Home as a direct way to tie it to setting the home page.

I’d like to easily set a number of “posts per page” for the home page of my site. Right now I think I have to use wp-admin (can’t remember.) Maybe I could add it here on the Home Page setting.

screen-shot-2017-02-14-at-16-12-13

Inside that page "card" area have a settings dropdown to change the number.

lancewillett commented 7 years ago

Ran into the Logged-out Follow thing today — was looking at my site https://simpledream.net and couldn't understand why the Follow links in actionbar were hidden. Turns out in wp-admin Reading Settings I'd toggled it off (not sure why).

I couldn't see a way to turn this back on in Calypso.

lancewillett commented 7 years ago

https://github.com/Automattic/wp-calypso/issues/3900#issuecomment-280490035

We also need to port (and update) the now incorrectly titled "Logged out users" setting that disables the follow option for both logged-out and logged-in users despite what the text says:

Let's not show this setting at all any more, and turn the Follow links on/off intelligently in the actionbar.

lancewillett commented 7 years ago

Good ideas from @mattsherman

I worry about these settings being hidden in a “Settings” item in the popover. But, we could increase discoverability of this if we were to list some of the key settings in the Blog Posts list row (where “Your latest posts, shown on homepage”). Would have to be careful not to clutter this up too much though.

Another option would be to make the “Blog Posts” itself clickable, taking you to the settings page. This would somewhat mirror the behavior of clicking on a page to edit it.

lancewillett commented 7 years ago

With D4527-code WordPress.com sites no longer show the Logged-out Follow wp-admin option.

lancewillett commented 7 years ago

Anecdote from @kathrynwp

When setting up a new site, I want to decide how many blog posts are displayed on the blog page, and how many portfolio projects are displayed on the portfolio. I can’t find a spot to change those numbers in Calypso, and I don’t know that WP Admin exists, so I have to find the relevant support pages (separate ones for blog and portfolios) and make my way to an interface I’ve never seen before. This leaves me confused about why there are two redundant dashboards, and whether it’s important for me to familiarize myself with the second one — this literally happened when my mom set up her site. Or if I’m not search-savvy, I have to contact support for help finding the settings.

@melchoyce Shared a mockup of what this would look like in the Customizer

screen shot 2017-04-13 at 08 39 12
rickybanister commented 7 years ago

We've already built Infinite Scroll for Jetpack sites. I'd love to sync up about this issue, since I think we can avoid adding the Reading tab to settings.

lancewillett commented 7 years ago

I think we can avoid adding the Reading tab to settings

Yes, please — let's avoid this by putting settings closer to where they'll likely be needed. For example, Delta is currently iterating on pages screen; so something like "Number of posts" to show on the Blog Page would go there (in that page's setting) rather than in Settings.

lancewillett commented 7 years ago

I split out this specific task: #13569

designsimply commented 7 years ago

Quick follow-up to note that the "Posts Per Page" setting was added to Settings > General in #13718, r155891-wpcom, https://github.com/Automattic/jetpack/pull/7154 and moved to Settings > Writing in #13916. Here is a screenshot of how it looks now for reference:

screen shot 2017-05-18 at thu may 18 1 59 14 pm Seen at https://wordpress.com/settings/writing/design5279.wordpress.com using Firefox 53.0.2 on Mac OS X 10.12.4.

designsimply commented 7 years ago

Since infinite scroll was mentioned specifically, I checked on it and it doesn't appear to be available in Calypso yet. Here's how it looks in wp-admin for reference:

screen shot 2017-05-18 at thu may 18 2 04 57 pm Seen at https://design5279.wordpress.com/wp-admin/options-reading.php using Firefox 53.0.2 on Mac OS X 10.12.4.

Also noting that the related image in the support documentation is old and this section should be updated when the infinite scroll setting is added to Calypso. See https://en.support.wordpress.com/infinite-scroll/#disabling-infinite-scroll (screenshot)

designsimply commented 7 years ago

A lot of changes have been happening in Settings lately! 🎉

Here is an audit of wp-admin > Settings > Reading:

  1. Front page displays → Customize > Static Front Page (screenshot)
  2. Blog pages show at most → Settings > Writing (screenshot)
  3. Syndication feeds show the most recent → missing in Calypso (screenshot)
  4. For each article in a feed, show → missing in Calypso (screenshot)
  5. Site Visibility → Settings > General > Privacy (screenshot)
  6. Related posts → Settings > Traffic (screenshot)
  7. Infinite Scroll Behavior → missing in Calypso (screenshot)
  8. Enhanced Feeds → missing in Calypso (screenshot)
  9. Follower Settings → missing in Calypso (screenshot)

I suspect the following settings will not be moved. Can you confirm?

rickybanister commented 7 years ago

Infinite scroll will get fixed up for .com sites and the posts per page setting will be moved to live with post types.

I can't speak to the other missing items you mention, @designsimply could you clarify who the 'you' in your question is?

designsimply commented 7 years ago

Anyone working on the project who feels confident about making a decision about those settings is who should reply. I would consider this open for discussion and something worth discussing but wouldn't assign it to any one person or team. A decision can be reversed in the future if needed. The reason for the ask is that closing the gaps between wp-admin and Calypso is currently high priority.

rickybanister commented 7 years ago

@lancewillett or @shaunandrews any thoughts on those last remaining Reading settings—does anyone have a sense of whether they need to be migrated to a new place? If they are requirements I can help wrangle solutions and new homes for them.

designsimply commented 7 years ago

Looking again. It would probably be good to keep "Syndication feeds show the most recent" and "For each article in a feed, show" and I would remove "Enhanced Feeds" and "Follower Settings" unless there are good arguments to keep them.

lancewillett commented 7 years ago

My vote is to not move those final four at all, and use smart defaults for all WP.com feeds. If people want to customize it further — they could eventually fit better with a WP.org site running Jetpack, use a plugin to do those advanced changes.

rickybanister commented 7 years ago

I like the sound of that.

lancewillett commented 7 years ago

Closing this issue now since it was an "umbrella" issue, and smaller tasks and changes can be tracked separately.