Cannot update non-WordPress.org plugins

[mmtr]

Steps to reproduce

• Spin up a JN test site.
• Set up Jetpack and connect it to WP.com.
• Install an outdated version of a non-WordPress.org plugin.
• Go to https://wordpress.com/plugins/manage/:site.
• Open the non-WordPress.org plugin details.
• Note the update notice.
• Click on "Update".
• Reload the page and see how the update notice appears again.

Since these plugins cannot be updated (p9dueE-1ho-p2), let's disable the update button to prevent users from clicking on it.

Originally reported by @jessefriedman in p4TIVU-9nb-p2

I have a plugin called PixelGrade on my personal website. It’s out-of-date and Calypso says I can’t “Autoupdate” the plugin because it’s not in the WordPress.org directory. However, it does allow me to manually update. At first, I was like “woah that’s cool”, then I was like “wait if you can manually update why can’t you auto-update?”.

Going through the manual update flow I realized the problem, it doesn’t actually work.

I need to update

I can’t autoupdate

I click Update and am told it was working

Success!

Fail! after refresh

[danhauk]

Using a plugin called AudioTheme that comes with a premium theme and not available in the WordPress.org repo. I was able to successfully update the plugin.

Plugin needs updating

Successful update

Refresh

[jessefriedman]

@danhauk can you confirm that it's not update in wp-admin? I thought mine had actually updated till I went to the wp-admin and saw it wasn't updated there. Then I went back to Calypso and it said it needed an update again.

If it did update I wonder if the theme hooked into the request somehow to get the files and update the plugin?

[mmtr]

I verified that the Jetpack Beta plugin is updated too from the "Manage plugins" (https://wordpress.com/plugins/manage/:site) page when clicking on the "Update 1 plugin" button (it's updated in WP Admin as well):

Couldn't test with the plugin details page though because Calypso refuses to open it for the Jetpack Beta plugin.

[danhauk]

@jessefriedman It's showing as updated in wp-admin as well.

[kriskarkoski]

Similar issue here for third-party theme updates: https://github.com/Automattic/wp-calypso/issues/39056

[stale[bot]]

This issue has been marked as stale and will be closed in seven days. This happened because:

• It has been inactive in the past 9 months.
• It isn't a project or a milestone, and hasn’t been labeled `[Pri] Blocker`, `[Pri] High`, `[Status] Keep Open`, or `OSS Citizen`.

You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation.