Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.4k stars 1.98k forks source link

Atomic: error when adding menu items in Customizer with VideoPress header #40535

Open lancewillett opened 4 years ago

lancewillett commented 4 years ago

On Atomic sites in Customizer — using the Twenty Seventeen theme, for example — with the VideoPress video header feature in Customize > Header Media it's not possible to add more items to the menu.

Looks like a JavaScript error blocks the action.

Steps to reproduce

  1. Atomic site, make sure VideoPress is active in Jetpack
  2. Activate Twenty Seventeen
  3. Go to Customize > Header Media, add video to header
  4. Save and reload customizer (not sure if this is necessary)
  5. Try to add items to the Menu from the Customizer

What I expected

Menu editor would work as normal to add items.

What happened instead

The sections (eg Pages, Posts, Categories) will not open to allow you to add new menu items.

Screenshot / Video

https://user-images.githubusercontent.com/1398304/110544861-3f202400-80e1-11eb-9c25-e106ce33df1e.mov

JavaScript error:

Screen Shot on 2020-03-07 at 13-37-17

Context / Source

User report/follow-up: ​2768458-zen

Reported by @kristarella in Trac: 8200-wpcom

ccwalburn commented 4 years ago

Another report for a site using the Ovation theme here: 3038003-zen

github-actions[bot] commented 3 years ago

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

obenland commented 3 years ago

Based on the JS error in the screenshot this seems to be a bug with the cookie banner widget. I wonder if it just didn't mount in the customizer, causing the error and https://github.com/Automattic/jetpack/pull/16927 fixed that.

@kristarella I've not been able to reproduce the bug based in the steps in the ticket description. Would you mind testing again and see if https://github.com/Automattic/jetpack/pull/16927 fixed it?