Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.42k stars 1.99k forks source link

Hosting / Atomic: Add Eligibility Check to Block Site Redirect Subscriptions #42533

Open JoshuaGoode opened 4 years ago

JoshuaGoode commented 4 years ago

@lakellie encountered an issue where sites with site redirect subscriptions cannot go Atomic. In reality, they shouldn't but some users add these subscriptions on accident and this breaks their flow.

This report is based on her findings. See internal report, 9F6qB-p2

If a site redirect subscription is present on an Atomic site, the site redirect will not work. So while we don’t want sites with a site redirect going Atomic until the site redirect has been removed, ideally there should be some sort of error message that appears if a site redirect is present, rather than a hanging/stalled transfer.

The suggestion is to add an eligibility check informing the user to remove the subscription to https://github.com/Automattic/wp-calypso/blob/2a3c6652a4c1bf0e23e8294643d7ca1f0e4a8797/client/blocks/eligibility-warnings/hold-list.tsx#L20

Steps to reproduce

  1. Create a BIZ plan WPCOM site
  2. Add a Site Redirect Subscription
  3. Attempt to go Atomic
  4. Calypso indicates that Blog Transfer Started but it never finishes

What I expected

For an error or eligibility warning to be present letting them know that the Site Redirect subscription needs to be removed.

@lakellie suggests something like the following.

The Site Redirect upgrade will no longer be compatible with your site. Please remove the upgrade from here: https://wordpress.com/me/purchases before proceeding.

What happened instead

Transfer process didn't initiate, Calypso stalled on Blog Transfer Started

Context / Source

Internal discussion: 9F6qB-p2

user-report

github-actions[bot] commented 3 years ago

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.