search

Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.42k stars 1.99k forks source link

Add info icon button with popover component #45449

Open razvanpapadopol opened 4 years ago

razvanpapadopol commented 4 years ago

Create a new Extract the newly created InfoTooltip component in @automattic/components package to render an info icon button which opens a tooltip when clicked.

Update: use this component also in the '@automattic/launch' package.

Hint: use core components for icon and tooltip.

Screenshot

Screenshot 2020-09-08 at 09 41 01

Context

There is an existing InfoPopover component with at least 39 usages in Calypso (eg: https://github.com/Automattic/wp-calypso/blob/master/client/my-sites/plan-features/item.jsx#L28-L33).

We should probably let them co-exist for now due to various custom styling (eg: https://github.com/Automattic/wp-calypso/blob/master/client/my-sites/plan-features/style.scss#L355-L360).

razvanpapadopol commented 4 years ago

The component has been created as part of https://github.com/Automattic/wp-calypso/pull/45490/ and we need to extract it from @automattic/domain-picker to @automattic/components. Updated description to reflect this.

bariOmymen commented 3 years ago

I want to take this issue. I have some questions if you don't mind answering

Harshit3211 commented 3 years ago

Hi, I want to take this issue. I am completely new to this open-source stuff.

lupus2k commented 1 year ago

Hello, can you please assign this issue to me?

Hey @royalpinto007, you can create a PR with this one, but FYI, @Harshit3211 worked on this PR to fix this issue, and we are waiting for a rebase.

vipulshetty commented 4 days ago

@razvanpapadopol is this issue still open \