Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.4k stars 1.98k forks source link

Editor: Editing Image in Classic Block Brings up Media Library #45480

Open macmanx2 opened 4 years ago

macmanx2 commented 4 years ago

Steps to reproduce

  1. Starting at URL: I primarily tested with https://mmxtest.wordpress.com/ but was able to reproduce on other WordPress.com sites as well.
  2. Add a Classic Block
  3. Add an image under the Classic Block.
  4. Click the pencil icon to edit the image.

It's very important to note that this is not a problem under WordPress(.org) 5.5.1.

What I expected

The image editing panel to appear.

What happened instead

The entire media library appeared.

Browser / OS version

Firefox 80.0.1, Safari 13.1.2, and Vivaldi 3.3.2022.39 under macOS 10.15.6 Also, Safari under iOS and iPadOS 13.7.

Context / Source / Video

This was initially reported at https://twitter.com/curseredbaron/status/1303187269818314752?s=21 where you can see a video of the problem in action too.

bsanevans commented 3 years ago

Also reported here: pbEMJv-au-p2 (Issue 3)

macmanx2 commented 3 years ago

Also reported at https://wordpress.com/forums/topic/classic-block-adding-media-inconsistencies/

github-actions[bot] commented 3 years ago

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

nerdysandy commented 3 years ago

Also reported here: pbEMJv-au-p2 (Issue 3)

I referred to the screen recording shared ^ in that post but I can't replicate it anymore. It shows the image details when I click on the pencil icon to edit it. Tested it on both Chrome and Safari: https://d.pr/i/bQuzVL

KokkieH commented 3 years ago

We've had another report of this in https://wordpress.com/forums/topic/classic-block-adding-media-inconsistencies-part-2/, and I'm able to reproduce on a test site, exactly as described above and as pictured on the P2 post, so reopening this.

KokkieH commented 3 years ago

Expected behaviour (classic block in the Core block editor):

Screen Capture on 2021-05-24 at 07-25-26

Expected behaviour (classic block in WP-Admin editor on WordPress.com simple site):

Screen Capture on 2021-05-24 at 07-28-44

Broken behaviour (classic block in Calypso editor on WordPress.com simple site):

Screen Capture on 2021-05-24 at 07-33-24