Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.39k stars 1.98k forks source link

Gutenboarding: review how to store wpcom features data #45699

Open ciampo opened 3 years ago

ciampo commented 3 years ago

PR #45221 extracted the features data to the @automattic/data-store package, so that they can be used in both Gutenboarding and wp-admin (and anywhere else).

The newly created @wordpress/data store, though, doesn't currently have any action, and thus only serves the purpose of storing static data — which makes using a store a bit overkill.

There are 2 possible approaches:

razvanpapadopol commented 3 years ago

Can we consider also a 3rd approach to extract Feature picker to an a8c package and export the component and also features data from there?

ciampo commented 3 years ago

Can we consider also a 3rd approach to extract Feature picker to an a8c package and export the component and also features data from there?

Extracting Feature Picker to a separate package sounds like a good idea.

Regarding the actual data, should it be stored in the feature-picker package (as a JS const), or should it be stored in the backend and retrieved via REST apis?

github-actions[bot] commented 2 years ago

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

razvanpapadopol commented 2 years ago

Feature Picker may continue to be used in post-site creation onboarding. cc: @Automattic/ganon-bloggers