Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.42k stars 1.99k forks source link

Premium Content: Subscribers cannot see content on renewal date #46242

Open mmtr opened 4 years ago

mmtr commented 4 years ago

According to PCYsg-4rX-p2, monthly and annual subscriptions that grant access to see premium content are renewed the day of expiry. I'm assuming they can happen at any time during the expiry day. However, the Premium Content block is not showing the protected content as soon as the expiry date is reached. In other words, between the expiry date at 00:00 UTC and when our async job renews the subscription, the plan is considered invalid and therefore the premium content is not visible to the subscriber.

A possible workaround is to add an additional day of grace to the expiry date check above, so the content is always visible regardless when the renewal happens:

if ( ( $end + DAY_IN_SECONDS ) > time() ) {
  return true;
}

Originally reported by @gwensmithx in p1602025594051900-slack-CDA5HLRD2.

github-actions[bot] commented 3 years ago

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

worldomonation commented 3 years ago

Hi! I'm performing triage on older bugs as part of Quality Squad's efforts to cut down on backlog issue counts.

I am removing the Stale label as this is a user-facing issue that can manifest itself in all sorts of unexpected ways for the customer.

rcrdortiz commented 2 years ago

Waiting on https://github.com/Automattic/wp-calypso/issues/52287 to be closed