search

Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.4k stars 1.98k forks source link

Starter Templates: RTL issues #46435

Open emilyaudela opened 3 years ago

emilyaudela commented 3 years ago

In some of the starter templates for Gutenboarding, the right-to-left elements are not correct. Please correct the right-to-left layout in these starter templates.

Maywood

  1. Starting at URL: https://wordpress.com/new/design/ar
  2. Select the Maywood template
  3. The heading and first paragraph or the second section is not aligned right in the preview

capture-decran-2020-10-13-155510

Alves

  1. Starting at URL: https://wordpress.com/new/design/ar
  2. Select the Alves template
  3. The "About" text block is not right aligned
Screen Shot 2020-10-13 at 8 19 25 PM

Stratford

  1. Starting at URL: https://wordpress.com/new/design/ar
  2. Select the Stratford template
  3. The "Services" and "Testimonial" headings should be right aligned.
Screen Shot 2020-10-13 at 8 23 43 PM Screen Shot 2020-10-13 at 8 22 37 PM
andrewserong commented 3 years ago

I think some of these are due to missing CSS rules in Varia or the child themes. @ramonjd has a PR for addressing Stratford in https://github.com/Automattic/themes/pull/2551, but I'm wondering if that same change needs to happen higher up the chain in Varia 🤔

ramonjd commented 3 years ago

wondering if that same change needs to happen higher up the chain in Varia

I took a poke around and saw that there is a rebuild-child-themes script in the pub/varia directory. 🤞 we can change it in one place and recompile.

simison commented 3 years ago

I think this would be best handled by theme team since it affects current themes and live sites. @scruffian what do you think?

scruffian commented 3 years ago

Yeah lets make this change in Varia and rebuild the children. Let me know if you need any help with this.

simison commented 3 years ago

@scruffian Yeah, was hoping if Theme-folks could take this whole fix over?

scruffian commented 3 years ago

Ok, added to the backlog. Not sure when we'll get to it...

danieldudzic commented 3 years ago

Hi all!

Thank you for bringing this to the attention of the Theme team.

We have looked at the issue together and were able to replicate it.

We believe that the culprit here are the templates themselves.

The faulty blocks have alignment set via Block settings.

A paragraph aligned to the left should and will display as aligned to the left both in LTR and RTL.

The resolution here is not a CSS fix, but rather the removing of unnecessary alignment settings from the blocks (setting it back to Default).

simison commented 3 years ago

Nice sleuthing @danieldudzi! 👏 @ianstewart can your team review the templates here? See above comment.

ianstewart commented 3 years ago

@simison 👍