search

Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.39k stars 1.98k forks source link

Move PageControl componenent into own package #47778

Open autumnfjeld opened 3 years ago

autumnfjeld commented 3 years ago

Move GB Guide component's PageControl into it's own package as it is a handy component on its own.

See use case: https://github.com/Automattic/wp-calypso/blob/trunk/apps/editing-toolkit/editing-toolkit-plugin/wpcom-block-editor-nux/src/welcome-tour/pagination.js#L6-L10

Mentioned in: https://github.com/Automattic/wp-calypso/pull/47354/files#r526591146

(I am putting this issue in this calypso repo and not GB to list it in the Ganon Project page.)

github-actions[bot] commented 2 years ago

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

razvanpapadopol commented 2 years ago

This issue continues to be valid since we're using the Welcome tour in production and a copy of PageControl is still hardcoded.