[Embed Block] YouTube private videos show as cut-off in the editor when embedding

Automattic / wp-calypso

The JavaScript and API powered WordPress.com

https://developer.wordpress.com

GNU General Public License v2.0

12.4k stars 1.98k forks source link

[Embed Block] YouTube private videos show as cut-off in the editor when embedding #48055

Open metabreakr opened 3 years ago

metabreakr commented 3 years ago

Steps to reproduce

Add a new YouTube block
Paste a link to a private YouTube video. For example: https://youtu.be/nkiDmcROytg

What I expected

To see a full-sized video placeholder (understanding that private videos do not show thumbnails), such as:

The private video shows as expected when viewing the site.

What happened instead

The placeholder appears either:

Cut-off, and not the full-height of the block in the editor only

There's a null error message: If the owner of this video has granted you access, please sign in

Context / Source

3540773-zen

cathymcbride commented 3 years ago

@jonnyruzek I'm not reproing. Is this simple? Atomic? Is it on a particular browser?

metabreakr commented 3 years ago

@cathymcbride It's an AT site. @philnick206 might be able to provide more details — I opened the issue on his behalf.

azollafox commented 3 years ago

I tried as well when I got this follow up ticket in play but couldn't reproduce on my Atomic site using Firefox as my browser. I've asked the user if we can get any further details from them on what browser they are using.

Just for safety's sake I'm also asking them to try clearing their cache, logging into YouTube and then WordPress.com to see if that solves the issue

iamgabrielma commented 3 years ago

I've asked the user if we can get any further details from them on what browser they are using.

I asked a few times but they just replied "the latest". ATM latest is Version 87.0.4280.88 (Official Build) (x86_64) , I couldn't reproduce this on my end.

cathymcbride commented 3 years ago

I repro on my AT site in Chrome (latest) & Firefox, in the editor only. I don't think this is browser related, as when I compare a private youtube and public youtube link in the code editor, the public one appears to be the youtube embed type and the private one is "rich"? Leaving on the janitor board for the moment.

JessBoctor commented 3 years ago

Came across this ticket in play:

– Re-tested and got the same error. It looks like the issue is that our embed block can't authenticate the user to allow the video to be shown

Found a couple of plugins that allow private videos to be shown on the site -- https://embedprivatevideo.com/embed-private-youtube-video-wordpress-plugin-pricing-plans/ -- https://wordpress.org/plugins/simple-private-video/
Let the customer know we don't know when there will be a fix.