Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.41k stars 1.99k forks source link

Editor: Media: Allow gallery items to link to arbitrary links #4943

Closed melchoyce closed 4 years ago

melchoyce commented 8 years ago

We should let people link individual gallery images to specific pages, posts, and external locations. It's a frequent request in the support forums, dating back to as early as 2010. Here are some example threads:

There's also a core issue for this request.

designsimply commented 6 years ago

bug-scrub #pre-gutenburg-bug-purge

I'm not sure why this has not yet been addressed in core. Will the gallery functionality be redefined in the Gutenberg Editor anyway? What do you think about closing this issue in Calypso in favor of following the functionality of core/Gutenberg for this enhancement request?

melchoyce commented 6 years ago

@karmatosed ^

karmatosed commented 6 years ago

The initial plan isn't to change much in the gallery (if at all) for Gutenberg. It's a block but we don't have extra functionality like linking to each image. We potentially will have captioning inline and a few polish bits.

designsimply commented 6 years ago

All righty! Keeping this open for now because it's not a near-future update for Gutenberg.

stale[bot] commented 5 years ago

This issue has been marked as stale and will be closed in seven days. This happened because:

You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation.

formosattic commented 4 years ago

As raised on p5cPuC-24l-p2, custom links for images in a gallery is now possible via the basic set of CoBlocks available by default on all sites, using the Masonry Gallery and Stacked Gallery blocks.

Screen Shot on 2019-11-14 at 13:23:02

@designsimply : is that enough of a solution to close this?

stale[bot] commented 4 years ago

This issue has been marked as stale and will be closed in seven days. This happened because:

You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation.

designsimply commented 3 years ago

I say it's up to the Calypso team whether to close this case—I don't feel strongly either way but do want users to have the options they're after and think its verywaycool that Masonry and Stacked gallery blocks now have a custom URL option. I just tried it out and I love it!

I still think it's worth adding the option for setting custom URLs for each image to the core Gallery block but perhaps it should be done as part of core WP Gutenberg work. 🙂