search

Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.42k stars 1.99k forks source link

People: able to send invites to users already on site #49848

Open worldomonation opened 3 years ago

worldomonation commented 3 years ago

Steps to reproduce the behavior

  1. As user 1, go to My Sites > Manage > People.
  2. Invite a new user, user 2 as any role other than Follower.
  3. As user 2, accept invite.
  4. As user 1, invite user 2 again in another role.
  5. As user 2, click on Accept invitation.

What I expected to happen

User 2 does not receive the another invite in the first place.

This is my expectation because of the error message shown (noted below) and the Support document page implying that Step 5 in the reproduce step should not have taken place.

Alternatively, if Step 5 is allowed to take place, clicking on the Accept invite should instead upgrade/downgrade the user role to the new level.

What actually happened

User 2 receives an invite email. After clicking on the Accept invitation link, user is instead told that:

You are already a member of this site.
Would you like to accept the invite with a different account?

Context

Back to basics user testing.

Browser / OS version

OS: macOS Big Sur 11.1 (20C69) Version 88.0.4324.150 (Official Build) (arm64) Browser: Safari Version 14.0.2 (16610.3.7.1.9)

Is this specific to the applied theme? Which one?

N/A

Does this happen on simple or atomic sites or both?

Tested on Simple.

Is there any console output or error text?

N/A

Level of impact (Does it block purchases? Does it affect more than just one site?)

Minor - user is able to manage role levels by clicking into the user from My Sites > Manage > People > Team. However, this is potentially confusing to users (I know I was thrown off by the chain of events).

Screenshot / Video: If applicable, add screenshots to help explain your problem.

Screen Shot 2021-02-08 at 5 32 45 PM

Screen Shot 2021-02-08 at 5 47 53 PM

Screen Shot 2021-02-08 at 5 47 01 PM

github-actions[bot] commented 3 years ago

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

mpkelly commented 2 years ago

Hi @worldomonation, I have tried reproducing this using the steps you added. I couldn't send a second invite because of a validation check.

image

So it looks like it's fixed already. Can you retest and advise if you're happy with the current solution?

I think we can improve the UX by linking the user to the admin page where they can change roles.