Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.42k stars 1.99k forks source link

Nav Uni: "Screen Options" and "Help" appear inconsistently #50508

Open xpurichan opened 3 years ago

xpurichan commented 3 years ago

Some pages in the nav uni show the "Screen Options" setting tab and "Help" tab in the top-right corner of the page, but others do not.

Steps to reproduce the behavior

Pages which don't show either of these two tabs:

Pages that do show both tabs:

Pages missing one tab or the other:

This is just a rough grouping I've come up with to help us identify when/where these options will load.

What I expected to happen

More consistency on when these two tabs appear, particularly the "Help" tab which I would expect to dependably find everywhere. It does make sense to me that "Screen options" don't appear everywhere as I know that is page-specific.

As far as I am aware we intent to but the familiar "?" help icon in the bottom-right corner of the dashboard. If so I think it would be helpful to remove the "Help" tab in the top-right corner to avoid confusion. Additionally that tab is focused on self-hosted websites and wouldn't make sense for WPcom customers to see anyways.

What actually happened

The display of these two option tabs is inconsistent

Context

Team testing

Browser / OS version

N/A

Is this specific to the applied theme? Which one?

N/A

Does this happen on simple or atomic sites or both?

Both simple and Atomic.

Is there any console output or error text?

N/A

Level of impact (Does it block purchases? Does it affect more than just one site?)

Minor impact/confusion, particularly on where to obtain help from.

Reproducibility (Consistent, Intermittent) Leave empty for consistent.

Consistent

Screenshot / Video: If applicable, add screenshots to help explain your problem.

Missing from https://wordpress.com/home/ : Screenshot: https://cldup.com/9HYBxxL-xt.jpg

Present on https://DOMAINCOM/wp-admin/plugins.php : Screenshot: https://cldup.com/F1wkvwj7ru.jpg

xpurichan commented 3 years ago

Semi related: https://github.com/Automattic/wp-calypso/issues/50509

obenland commented 3 years ago

Screen Options and Help are Core features and contextual to the screen they appear in. I'm not sure I share the expectation of consistency for either—as you pointed out with Jetpack—screens added by third-party plugins will likely not offer any of the two.

The ? icon has been added now, providing a constantly available option to get help. Is that a satisfactory stop-gap solution until we get to further flesh out the FAB icon in wp-admin?

kdevnel commented 3 years ago

Just to add to this - in a specific case discussed here - p1627136650040200/1627134981.031100-slack-C03TY6J1A - we had no Screen Options toggle on the user list and user had to directly visit the WP Admin URL to update their local site URL with SSO turned off.

I believe we suggested restoring the "Advanced User Management" menu option instead of adding Screen Option where they wouldn't normally appear in WP Admin.

sguzovskaia commented 3 years ago

Adding a similar case: none of the pages are showing the "Screen Options" setting tab in the top-right corner with disabled Jetpack SSO for the customer with a ticket zen-4178686.

I had to give them the direct link to WP Admin Pages to access Classic Editor.

Nic-Sevic commented 3 years ago

Another case here where the user wasn't seeing the option on the pages or posts screens with sso off - 4241854-zd-woothemes