search

Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.42k stars 1.99k forks source link

Themes: Do not feature Varia parent theme on Atomic. #51335

Open ianstewart opened 3 years ago

ianstewart commented 3 years ago

Steps to reproduce the behavior

Potentially related to the installation of WooCommerce and how Storefront is surfaced in that instance. See https://github.com/Automattic/wp-calypso/issues/51332

  1. Create a site on WP.com
  2. Install WooCommerce
  3. Visit themes showcase on WP.com
  4. Click the more button to show all themes
  5. See Varia prominently featured

What I expected to happen

Varia would be at the bottom of the list of themes as it is on Simple Sites. It needs to be somewhere in the list to act as a Parent Theme to Child Themes. But it should not be prominent.

What actually happened

image

ianstewart commented 3 years ago

@jeffikus @simison @jffng I think — or rather I think —  we can perhaps retire Varia on WP.com and it's child themes would still work? That appears to be the case with the themes named Superhero and Sidekick. It would need testing but that could be a simple solution to this that would be generally good for everyone. It's not intended that users should be activating Varia.

simison commented 3 years ago

@jeffikus I'll add this to our backlog but I have a hunch that the theme team would already know what to do to "retire Varia on WP.com", and for us, it's gonna be a learning curve. Wanna grab this for your backlog instead?

jeffikus commented 3 years ago

@simison @ianstewart we're checking on if there are any implications on Atomic before doing a retirement as usual.

ianstewart commented 3 years ago

Sounds good.

kwight commented 3 years ago

@jeffikus 👋 Any update on this?

DanielSmithMichigan commented 3 years ago

Themes is divided into sections. The first few themes after the "advanced" section are the "Uploaded themes."

I think varia being uploaded as a theme is due to using a parent theme of another theme and then beginning an automated transfer.

What I'm wondering is: will "retiring" varia prevent it from showing up in the "uploaded-themes" section?

image

ianstewart commented 3 years ago

In that screenshot, if you were to switch to Spearhead from Alves, would Dotcom upload Spearhead too? I'm wondering how Alves and Varia and Twenty Twenty One even got in there.

DanielSmithMichigan commented 3 years ago

In that screenshot, if you were to switch to Spearhead from Alves, would Dotcom upload Spearhead too? I'm wondering how Alves and Varia and Twenty Twenty One even got in there.

It seems like your currently active theme is always in the "Uploaded Themes" section, and it remains there afterward as well. If I switch to Spearhead, then Spearhead is added to the "Uploaded Themes" section.

I never interacted with Twenty Twenty-One, so I'm not sure what's going on there.

These are the steps I followed to create that screenshot:

  1. New site
  2. Select "Alves" during setup
  3. Install Buddypress
  4. Activate Spearhead

It seems like the parent theme ends up in "Uploaded Themes" only when it is the parent theme of the theme which was active at the time your site was upgraded to atomic.

For example, if I do this:

  1. New site
  2. Select "Blank Canvas" during setup
  3. Install Buddypress

Then I end up with Seedlet, Blank Canvas and Twenty Twenty-One

As far as I can tell, Varia is not the parent theme of Storefront, so the original screenshot is still confusing. But I imagine you selected a varia based theme during setup.

This was me installing WooCommerce just now, after selecting "Blank Canvas" for my design

ianstewart commented 3 years ago

@DanielSmithMichigan I think I know what's happening.

Example for the last point. I started with Blank Canvas, a child theme of Seedlet, before going Atomic, and then after going Atomic I switched to Twenty Twenty.

image

When creating a site via the ecommerce flow I can pick Blank Canvas and the defaults are the same — except we pre-install Storefront and a few storefront child themes.

image

As far as I can tell, Varia is not the parent theme of Storefront, so the original screenshot is still confusing. But I imagine you selected a varia based theme during setup.

This is what happened.

I think we have another issue about never showing Varia on simple sites. We probably have to display it on atomic sites however as installed as we allow users to use the theme editor on Atomic.

image

I think we might have wontfixed this one?

kwight commented 3 years ago

I think we have another issue about never showing Varia on simple sites.

@ianstewart Maybe that's https://github.com/Automattic/wp-calypso/issues/49039 ?

DanielSmithMichigan commented 3 years ago

I think we have another issue about never showing Varia on simple sites. We probably have to display it on atomic sites however as installed as we allow users to use the theme editor on Atomic.

@ianstewart Can you clarify more about this point?

Suppose we planned to use css to hide themes which haven't been installed, how does the theme editor prevent us from moving forward with that plan?

DanielSmithMichigan commented 3 years ago

I think we might have wontfixed this one?

I'm just now finishing up with another issue (https://github.com/Automattic/wp-calypso/issues/53473).

@ianstewart @kwight As for this issue, should we close it or should I return to it?

ianstewart commented 3 years ago

Suppose we planned to use css to hide themes which haven't been installed, how does the theme editor prevent us from moving forward with that plan?

Varia appears to be installed when one of it's child themes is installed when it is the active theme on theme switch. A child theme inherits some or all of it's parent theme styles and template code. So, with the theme editor available to users on Atomic sites we should allow users to have access to Parent Theme styles and templates.