search

Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.42k stars 1.99k forks source link

"My Site" button behavior #51347

Open AtrumGeost opened 3 years ago

AtrumGeost commented 3 years ago

What Before Nav Unification, the "My Site" button would always direct to "My Home".

Now, if you are already in the WordPress.com Dashboard (Nav Unification) clicking on "My Site" doesn't do anything.

I'm not sure if this intentional, so I checked the Reader button, and I can see when I'm on the Reader, clicking on the "Reader" button brings me back to "Followed Sites".

Why It would be great to have consistency on how the "My Site" and the "Reader" buttons work. Users can think the "My Site" button is broken since when they click on it, it doesn't do anything.

How We could opt for the previous behavior which is to always direct to "My Home" when clicking on "My Site".

mrfoxtalbot commented 3 years ago

I got two users who run into the same issue yesterday. One was using the Nav unification (28027357-hc) but the other one was not (28686266-hc).

obenland commented 3 years ago

I wonder if that is a style issue that was introduced with the recent color scheme work, where the active tab just doesn't appear active anymore?

In Modern it's harder to tell than in Blue for example: Modern Blue
Screen Shot 2021-04-06 at 3 09 58 PM Screen Shot 2021-04-06 at 3 11 07 PM

We're not super flexible on the Core color schemes, but maybe this could be made clearer in the ones we added?

obenland commented 3 years ago

Oh, and it looks like "Classic Blue" even has a third color there. Maybe this is something we can change for Core color schemes?

image

csonnek commented 3 years ago

User reporting this problem in: https://wordpress.com/forums/topic/support-article-add-email/#post-3663333

I can reproduce by doing the following:

  1. Go to any theme demo page - e.g. https://wordpress.com/theme/blank-canvas
  2. Click the "My sites" link expecting to go to your My sites list.
  3. You don't go anywhere.

The href seems to be the same page that you're on rather than https://wordpress.com/sites like I would expect to navigate to. This happens on any theme demo page that I tried out of a random sampling.

obenland commented 3 years ago

@csonnek Which color scheme do you use?

We should also override the cursor: pointer property when My Site is selected. We keep an anchor element with an empty href attribute, which doesn't feel right.

csonnek commented 3 years ago

I use "Nightfall" and it looks like the forums user has "Classic Blue".

zdenys commented 3 years ago

Issue

With Classic view (aka WP Admin aka Nav Unification), the My Site button changes its behavior. When clicked it opens the site in the same tab. This is confusing because leaving the dashboard is not optimal.

Suggested solutions

One should remain in the same context or, if the above behavior needs to be kept, at least make the site open in a new tab, similar to this request https://github.com/Automattic/wp-calypso/issues/55896.

Or keep the behavior the same as on Simple Site or on Atomic one in WordPress.com View) where it opens the preview of the site in a modal window without navigating away.