Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.42k stars 1.99k forks source link

Customizer: Can't crop header images. #52182

Closed JessBoctor closed 1 year ago

JessBoctor commented 3 years ago

Steps to reproduce the behavior

  1. Activate a theme that uses a custom header image:
  2. Go to My Site > Appearance > Customize > Header Image
  3. Click on Add new Image
  4. Select and image and then click on Select and crop

What I expected to happen

To be able to crop the image to the correct header size and then save it to the header

What actually happened

When you get to the next screen, there is no cropping selection. Dragging across the image to create a selected section results in Drop image. Clicking on Crop results in the error {file name} There has been an error cropping your image. if there is a Skip Cropping option and you select it, it does not update the header image

There is a video of my test site here: https://d.pr/v/0kpjbn

Context

Customer reported this in #29153016-HC

Browser / OS version

Mac OS 10.15 / Chrome 89

Customer was using Windows 10 with Chrome 83

Is this specific to the applied theme? Which one?

First reported on Dynamic news, but I have also tested Dara and Intergalactic and had the same issues

Does this happen on simple or atomic sites or both?

Simple. The cropping function works as expected on AT sites

Is there any console output or error text?

No

Level of impact (Does it block purchases? Does it affect more than just one site?)

It affects more than one site, but doesn't seem to prevent other editing of the site

Reproducibility (Consistent, Intermittent) Leave empty for consistent.

Screenshot / Video: If applicable, add screenshots to help explain your problem.

rw-ye commented 2 years ago

Another report: 5198482-zd-woothemes

Shared workaround

jamiepalatnik commented 2 years ago

Another report: 18057443-hc

Zooming out worked as a workaround.

jp-imagines commented 2 years ago

Another in 35512156-hc. Shared the workaround of zooming in/out in their browser to have the cropping controls appear.

jp-imagines commented 2 years ago

Another report in 35618497-hc, though this was for their site logo (not the header image). Same error, same zooming workaround worked.

rinazrina commented 2 years ago

Another report: 35631326-hc

donalirl commented 2 years ago

Seen in #5341259-zen

The error appeared when trying to upload then crop an image of 1008 x 756. However, when I uploaded an image using the theme's recommended size of 960 × 260, it worked.

cuemarie commented 2 years ago

I had a user encounter this issue in both Safari and Firefox browsers, here: 7691737-hc

We tried zooming their browser out and back in multiple times, and that never resolved the issue. Some specifics they shared:

Yes, I'm asked ? Crop Image; then "Crop" and the error appears. I'm not at the point where cropping lines appear before I get the error message.

Before hitting "Crop Image", I tried - two different prrocess attempts - CMD -, and on a second attempt: CMD 0. Both resulted in the error message.

Error:

Markup on 2022-08-03 at 13:43:06

Resolution:

I ended up making an exception and helped them set the image they wanted, as the issue was not presenting on my side.

github-actions[bot] commented 2 years ago

Support References

This comment is automatically generated. Please do not edit it.