Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.41k stars 1.98k forks source link

Domains: Mobile improvements #52905

Closed ollierozdarz closed 3 years ago

ollierozdarz commented 3 years ago

Edit: Some of the changes will be added in #53768 (follow up of #53700)

Based on the current performance of the refined reskin onboarding flow, let's make the following changes to help increase the likelihood of reaching parity (and beyond) with control.

Main improvement areas:

Refined Reskin

StefanNieuwenhuis commented 3 years ago

image (1)

Currently, the marketing copy hides the search results below the fold.

@ollierozdarz, what do you think of moving the marketing copy below the search results? See p1620915194324400/1620913276.320500-slack-C01VA100LEA

StefanNieuwenhuis commented 3 years ago

@ollierozdarz , another one is that the marketing copy is spread over 2 columns. WDYT? Does its layout need to change as well?

Another issue is that the off-margins around the search bar and is the search bar in the right place?

image (2)

ollierozdarz commented 3 years ago

Hey @StefanNieuwenhuis,

Currently, the marketing copy hides the search results below the fold. @ollierozdarz, what do you think of moving the marketing copy below the search results?

Yep, if you check out the latest mobile design in the description (and below), we'll put the marketing copy at the bottom underneath the results once they're populated:

image

Another one is that the marketing copy is spread over 2 columns. WDYT? Does its layout need to change as well?

The implementation for tablet view should look similar to below, with the input staying in the same place.

Another issue is that the off-margins around the search bar and is the search bar in the right place?

Yep, it looks off by a lot.

Screen Shot 2021-05-21 at 4 52 45 pm

The tablet view once the domains list is populated will need some more thought, but let's leave this until I'm back from AFK and I'll design a better solution from our latest learnings.

razvanpapadopol commented 3 years ago

Thanks for your input, @ollierozdarz 🙌🏼

we'll put the marketing copy at the bottom underneath the results once they're populated

@StefanNieuwenhuis, let's do the same also for tablet view (when we have marketing on 2 columns) and we can always improve later.

razvanpapadopol commented 3 years ago

https://github.com/Automattic/wp-calypso/pull/53700 was reverted in https://github.com/Automattic/wp-calypso/pull/53820 to fix the following regressions on Domains step:

Expected

Screenshot 2021-06-18 at 19 02 48

UI regression

Screenshot 2021-06-18 at 17 12 36