Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.42k stars 1.99k forks source link

Categories & Tags slugs: No option to edit slug in Simple sites #53932

Open devNigel opened 3 years ago

devNigel commented 3 years ago

What plan tier is the site on?

Free, Personal, Premium

Where are you seeing the issue?

  1. Go to Tags or Categories page.
  2. Try to create a new tag / category or edit an existing one.
  3. You will notice there is no option to edit slug for Simple sites.

What I expected on the WordPress.com site

Ability to edit slug

What I expected on the Atomic site

Ability to edit slug

What actually happened

Simple sites don't have the ability to edit slugs of Tags / Categories,

Is this specific to the applied theme? Which one?

No

Screenshot / Video: If applicable, add screenshots to help explain your problem.

Simple site:

image

Atomic site:

image

rw-ye commented 3 years ago

4249058-zd-woothemes 31322107-hc

I was asked about this in chat today.

davipontesblog commented 3 years ago

Adding to simple/atomic pod for consideration. This feels odd that it's not available on simple sites.

davipontesblog commented 3 years ago

@Robertght cc'ing you here to keep an eye on this one since if Simple Atomic pod aren't able to pick this up it might be worth our while exploring if Flow Patrol pods can, it seems like a low hanging fruit at first glance.

devNigel commented 3 years ago

Please update the user via a new ticket once this issue is resolved.

Ticket: 4249058-zen

arcangelini commented 3 years ago

Personal testing

Spent some time looking into this and it seemed to go away as I was testing. I was not able to replicate this in Tags, Categories, SImple, or Atomic. I briefly hit a snag with permissions but that was due to deleting a parent category.

Screenshot

Screen Capture on 2021-09-11 at 12-54-33

User site testing

I also took a look at the site listed in the ticket/chat above. I saw the same thing on this site. Permission error when attempting to edit certain categories, but no problems with new categories. Despite the permission error, the change was still saved. I would suggest asking them to recreate some of these categories and see if that works. @devNigel would you mind pinging them about this?

Screenshot

Screen Capture on 2021-09-11 at 13-03-32

Screen Capture on 2021-09-11 at 13-05-12

These screenshots will expire in 30 days

devNigel commented 3 years ago

Hi @arcangelini , I am confused. It seems you intended to reply to some other GitHub issue.

This issue is about feature parity between Atomic and Simple sites for editing the slug for categories and tags.

arcangelini commented 3 years ago

Oof long day... I completely misread that. Please excuse me @devNigel

thedebian commented 3 years ago

Please update the user via a new ticket once this issue is resolved.

Ticket: 4249058-zen

Just a quick update, the user got back to me today in chat n. 31366046; I was a bit confused at first about the feature they were asking about but saw this ticket; I let them know they'll be updated when we have news.

pablinos commented 3 years ago

I've been looking into the cause of this, suspecting that it was related to global terms, and that appears to be the case. When global terms is enabled the slug field is removed from the edit form.

We do have that enabled on simple sites, and I don't think we're in a position to turn it off, as that would affect a number of other features. There will be some history as to why slugs can't be edited, but I don't know what that is. I can imagine it could cause problems with knowing the intention. It would probably have to assume that we wanted to create a new category with the same name, but a different slug, or we would need the ability to associate different slugs with a global category on a per blog basis. At the moment the relationship between slugs and terms is one to one.

Either way I think this is something that would need to be worked on it in core, so we should probably raise a ticket there. Tracing through the history of the a bit I can see where global terms became optional, which was some time ago, so it could be time to refine it further.