Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.43k stars 1.99k forks source link

Customizer: Favicon not showing in Safari Mobile Bookmarks #54147

Open JessBoctor opened 3 years ago

JessBoctor commented 3 years ago

Steps to reproduce the behavior

  1. Go to My Site > Appearance > Customize > Site Identity and set a site icon. Save changes
  2. Open the website in Safari mobile
  3. Add the site to the bookmarks
  4. The icon doesn't appear in the bookmark manager options

What I expected to happen

The site Icon to appear to the left of the bookmark description and URL.

Here is an example from bookmarking the WordPress.com site:

Screen Shot 2021-06-29 at 3 41 05 PM

What actually happened

There is just a blank logo space.

See:

Screen Shot 2021-06-29 at 4 19 35 PM

Compared to mobile Chrome on iOS:

Screen Shot 2021-06-29 at 4 22 09 PM

Context

Reported by user in #30393940-HC User follow up is in #4104644-ZD

Browser / OS version

Safari 14 iOS

Is this specific to the applied theme? Which one?

No

Does this happen on simple or atomic sites or both?

Atomic only

Is there any console output or error text?

Not that I can see

Level of impact (Does it block purchases? Does it affect more than just one site?)

Affects multiple sites, does not block purchases

Reproducibility (Consistent, Intermittent) Leave empty for consistent.

Screenshot / Video: If applicable, add screenshots to help explain your problem.

See screenshots above

wpericam commented 3 years ago

Tested and reproduced. I also noticed the favicon not showing in Chrome desktop when typing a site address into the address bar.

WordPress.com Site Example

favicon-bug-testing

Google.com Example

Favicon-Bug-Testing2

*I obfuscated the specific sites and URLs being recommended because they from my personal browsing history

wpericam commented 3 years ago

Never mind the above comment. Once I launched the site, the favicon showed up in the place I mentioned, as well as others I was planning to add.

The launching of the site did not correct the Safari mobile bookmarks behavior though.

zachspears commented 2 years ago

Able to reproduce and seeing the same issue: IMG_1173FBCAFBE4-1 :

thekingsprojects commented 2 years ago

Another case here: 35630263-hc , follow-up 5266035-zen

I don't have an iPhone to check this with myself, and previous HEs haven't been able to replicate, but the user saw this issue and said it sounded like the problem they were experiencing.

I've seen other (likely unrelated) cases of favicons not showing up in Chrome that were resolved by adding a bunch of favicon files, including an apple-touch-icon.png file, to the site's root with SFTP, so I've advised the user to try that as a workaround while this is being looked at.

nicolynramos commented 2 years ago

Another here: 5353812-zen

pauljacobson commented 2 years ago

Also reported here: 5461908-zen

I tested adding a bookmark of our user's site to my Android device's screen and the site icon displays. This seems to be primarily an iOS issue. I was able to reproduce this issue on Browserstack on iOS 15.6:

https://user-images.githubusercontent.com/2912202/183420192-5189f9f7-d66c-4688-a999-6de1a01b1a05.mp4

github-actions[bot] commented 2 years ago

Support References

This comment is automatically generated. Please do not edit it.