Paragraph Block: Selecting Color from Toolbar doesn't change text color in editor

ccwalburn commented 3 years ago

2023-10-04 update - this issue has been remained open as themes are fixed on a theme-by-theme basis. The only remaining theme that this is currently waiting on is Karuna. See latest comments

When you select some text in a Paragraph block and change the color using the Font Color option on the toolbar, it changes the color on the front end, but not in the editor.

Steps to reproduce the behavior

Activate the Rebalance theme
Create a new post and add a Paragraph block
Add some text to the Paragraph block; highlight one word in the text and click the Text Color option under the down arrow on the toolbar:

![screenshot](+) Image URL:

Select a color
Publish the page.

What I expected to happen

I expected to see the font color in the Paragraph block change in the editor.

What actually happened

The font color was added to the Paragraph Block toolbar, but it didn't change the font color in the editor:

![screenshot](+) Image URL:

However, the font color did change on the front end:

![screenshot](+) Image URL:

Context

Browser / OS version

I was using Chrome on Mac version 10.15.7

Is this specific to the applied theme? Which one?

I've been able to reproduce it on Rebalance and Dara. I tried testing on Dalston, Twenty Twenty, and Ryu but couldn't reproduce there. It seems like it may not happen on Recommended themes.

Does this happen on simple or atomic sites or both?

I only tested on Simple Sites

Is there any console output or error text?

Level of impact (Does it block purchases? Does it affect more than just one site?)

I have only had one report, but I can reproduce it on my test site.

4173857-zen

Reproducibility (Consistent, Intermittent) Leave empty for consistent.

Screenshot / Video: If applicable, add screenshots to help explain your problem.

inaikem commented 3 years ago

Thanks for raising this issue! I am able to replicate on my test sites.

Wondering if this and When Headings Font Size Set in Customizer, Type Scale is Ignored on Blog Posts Block Post Titles (#54911) are somehow related?

alshakero commented 3 years ago

Can confirm reproducing this. It's reproducible in Rebalance theme, but not all themes. We'll investigate the issue today.

alshakero commented 3 years ago

PR ready here https://github.com/Automattic/themes/pull/4359

tellisbethel commented 3 years ago

I believe I've encountered a version of this bug here: 4233694-zen The only difference is that when selecting the text colour, the text changes to the wrong colour in the editor (instead of not changing at all), but then reflects the correct colour when previewing or on the live site.

goblinartificer commented 3 years ago

An interesting rendition in 4257432-zen today: the colors look right until you try to apply any other text decoration, then only the bold/underline/etc shows up. The preview is right, but the editor is wrong.

hacchism commented 3 years ago

Another instance in 4293838-zen with Canard theme.

thekingsprojects commented 3 years ago

Also seeing this in the Aquene theme: 14276663-hc and replicated on my own test site. Not sure if we're doing anything about that given that's a retired theme now, but worth noting, I suppose.

sbathompson-he commented 3 years ago

Experienced this bug on the Affinity theme here: 30538090-hc

tellisbethel commented 3 years ago

Preview colour is right but colour in editor when using the palette (not the picker) is wrong: 30511716-hc Simple site.

alshakero commented 3 years ago

Hi @scruffian! I have sent a PR to fix this issue earlier. It's probably a bad PR but will give you a clear idea about this issue. Can you please give it look? Thanks!

EjayhanFernandes commented 3 years ago

This occurred as well here 4320518-zen. Theme: Gateway by Rescue Themes.

ahmadbaig1 commented 3 years ago

User returned and requested a quicker resolution 31830828-hc.

inaikem commented 3 years ago

@Robertght, do you think this is something for Flow Patrol could look into?

Robertght commented 3 years ago

Thanks! I've added it now. cc @Automattic/flow-patrol-create

benchilcote commented 3 years ago

Adding another report - 22972062-hc

Theme isola. Simple site.

ccwalburn commented 3 years ago

Another report - 4335926-zen Theme: Lovecraft

dcoleonline commented 3 years ago

Reported in 31927285-hc Theme: Baskerville 2 We should follow up in 4337424-zen

Example:

nicolynramos commented 3 years ago

Another report for Lovecraft, simple site - 31984931-hc

kosiew commented 3 years ago

Hi @nicolynramos ,

Thanks for reporting this

I could reproduce this on a Simple site and Atomic site on the Lovecraft theme.

kosiew commented 3 years ago

I also tested that the on Rebalance, the Paragraph block text color does change.

scruffian commented 2 years ago

I believe this will be fixed by https://github.com/WordPress/gutenberg/pull/35514. It might take some time for that commit to make it to simple/atomic sites....

mzitinfo commented 2 years ago

We just had another case of this in 4368273-hc, with the Independent Publisher theme.

KokkieH commented 2 years ago

The Text Color option appears to be completely missing from the toolbar drop-down: New_Post_‹_kokkiestrialtestsite_—_WordPress_com

There's also now a Highlight option which isn't present in the screen shot at the top of this issue, which makes me wonder if #57036 might be somehow related.

Missing Text Color option pointed out by user in https://wordpress.com/forums/topic/no-colors/

KokkieH commented 2 years ago

It appears this is intentional. See #57054.

DjamWork commented 2 years ago

Maybe another case here zd-4379749 user wants to change the link color.

Nic-Sevic commented 2 years ago

Another instance here: 27931525-hc

Also +1 to labelling this as text highlight being confusing. I would expect highlight to change just the background color, not the text itself

as-esu commented 2 years ago

4657930-zen I could reproduce the issue using the Karuna theme, but only if I choose the suggested colours. Picking custom colour, reflected changes in the editor.

francoishvz commented 2 years ago

Another instance here: 35792663-hc

Workaround was to pick a custom color.

cometgrrl commented 2 years ago

I could reproduce the issue using the Karuna theme, but only if I choose the suggested colours. Picking custom colour, reflected changes in the editor.

Same for me (although white is suggested and displayed correctly in the editor, none of the others worked).

github-actions[bot] commented 2 years ago

Support References

This comment is automatically generated. Please do not edit it.

[ ] 4173857-zen
[ ] 4233694-zen
[ ] 4257432-zen
[ ] 4293838-zen
[ ] 4320518-zen
[ ] 4335926-zen
[ ] 4337424-zen
[ ] https://wordpress.com/forums/topic/no-colors
[ ] 4657930-zen

cometgrrl commented 2 years ago

@jeffikus Can you take a look at this? It seems there's at least one more theme (Karuna) that's affected by this bug.

cuemarie commented 1 year ago

📌 ACTIONS

Due to the age of this issue, I've downgraded the priority from High to Normal to better reflect it's status in the larger context of open bugs in the repo.
Looks like this is getting fixed at the theme level, which is why it's still open - waiting on a fix for Karuna:

https://github.com/Automattic/wp-calypso/assets/27249804/5d3c129a-3452-4d5e-b06f-b08a6dd6c760

CC: @Automattic/theam

alaczek commented 1 month ago

This is fixed now in Karuna too. Closing.

Automattic / wp-calypso