Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.43k stars 1.99k forks source link

Notification Icon disappears when active #56508

Open rossanafmenezes opened 3 years ago

rossanafmenezes commented 3 years ago

Quick summary

This is very specific, but you click on the notification bell under any of the WooCommerce tabs it disappears (the bell icon). On the other tabs, it works as expected.

Steps to reproduce

1 - access the dashboard of a site that has WooCommerce installed and the store is all set 2 - Click on the Notification Icon (the bell) at the top right corner of the page 3 - see the notification slide show and the bell icon disappear

What you expected to happen

I would expect the icon to either stay there as it does for other tabs after you click on the notification bell

This is the behaviour on the other tabs

What actually happened

On a site with a WooCommerce store set up the bell changes to black

Woo Store set up

However, please note if you have woo installed but did not set up the store the icon works

Woo w/o a store set up

Context

This was something I noticed while I was doing some tests on the Woo mobile app notifications. I was not getting the notifications on my mobile and accessed it from the browser to investigate my own notification settings. Brought it up to the PAs' attention and was directed to create a bug report for that.

Operating System

macOS

Browser

Google Chrome/Chromium

Simple, Atomic or both?

Atomic

Theme-specific issue?

No

Other notes

No response

Reproducibility

Consistent

Severity

No response

Available workarounds?

No response

Workaround details

This is a design issue more than anything else but can get users confused.

inaikem commented 3 years ago

On notification bell click, <li id="wp-admin-bar-notes"> ... </li> has the following classes added to it:

menupop mb-trackable wpnt-stayopen wpnt-show active

...this causes the following elements to be affected by color and background-color changes in CSS.

<div class="ab-item ab-empty-item"> ... </div>, <span id="wpnt-notes-unread-count"> ... </span> and <span class="noticon noticon-bell"></span>

The changes override the default CSS background below:

#wpadminbar #wp-admin-bar-notes.wpnt-show > .ab-item {
    background: #f5f5f5;
}

...to be: background: #26292c !important;

IMPORTANT:

inaikem commented 3 years ago

@Robertght, is this something Flow Patrol can be tasked to review?

Robertght commented 3 years ago

Thank you for the ping @inaikem !

I can confirm the issue is only present while you're in the WooCommerce dashboard.

Flagging this for @Automattic/flow-patrol-spacelab