Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.42k stars 1.99k forks source link

FSE: Link to the site editor (instead of customizer) when appropriate in 'plans' section #57210

Closed zaguiini closed 2 years ago

zaguiini commented 3 years ago

Details

As we were updating the theme changed modal on #57125, @creativecoder spotted an issue where the behavior will not match whenever someone upgrades the plan and has an FSE theme active.

Currently, it links the customer either to the Gutenberg front page editor or to the customizer URL, however:

image

Additional information

Component name: PremiumPlanDetails

Checklist

Related

57125

Addison-Stavlo commented 2 years ago

Are we still talking about the theme changed modal having inconsistencies in this state? Or a different section altogether?

In your screenshot, is that link on MyHome or somewhere else?

creativecoder commented 2 years ago

That screenshot is a features list on the checkout page that you see after you upgrade a plan, showing the features that come with the plan. You can also see it at https://wordpress.com/plans/my-plan/{site}

Addison-Stavlo commented 2 years ago

Ah yes, that makes sense.

Even with the new plans I am seeing this at https://wordpress.com/plans/my-plan/{site} :

Screen Shot 2022-05-25 at 12 33 46 PM

Where we are surfacing the customizer for these actions when on an FSE theme.

creativecoder commented 2 years ago

Let's hold this for Anthony next week (can't find a Github handle?), I think it would be a good initial Calypso issue for onboarding.

creativecoder commented 2 years ago

cc @agrullon95

creativecoder commented 2 years ago

Resolved by https://github.com/Automattic/wp-calypso/pull/64423