search

Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.43k stars 1.99k forks source link

Atomic Domains: Improve Calypso's error messaging for issues setting a primary domain #59366

Open JoshuaGoode opened 2 years ago

JoshuaGoode commented 2 years ago

Quick summary

Users might encounter issues setting a primary domain if the domain has already been used with another Atomic client.

In these cases, Calypso shows a success message: Primary domain changed: all domains will redirect to [domain]

However, the domain is not set as the primary.

Screen Shot on 2021-12-17 at 18:06:59

Extended report available internally at p9F6qB-7QU-p2

Steps to reproduce

Internal notes at p9F6qB-7QU-p2#comment-44342

What you expected to happen

Calypso to display a relevant error and recommended next steps.

What actually happened

Calypso incorrectly states Primary domain changed: all domains will redirect to [domain]

Simple, Atomic or both?

Atomic

Available workarounds?

Yes, easy to implement

Workaround details

Internal documentation available at P9HQHe-1dG-p2

Robertght commented 2 years ago

@Automattic/pod-domains is this something you can take a look into?

delputnam commented 2 years ago

@Automattic/pod-domains is this something you can take a look into?

I've added a task for us to handle this at some point. It's a low priority at the moment though.

delputnam commented 1 year ago

The original report didn't mention the domain, so I couldn't go back and look at the logs, but this might be related to a bug that was causing A records to be incorrectly removed for some atomic sites. This was fixed in D92482-code.

JoshuaGoode commented 1 year ago

@delputnam there are some details on p9F6qB-7QU-p2 as this is a separate issue.

I can set up an example for you if you'd like -- mostly just need to set up a site on another WP Cloud client like Pressable, add a domain there, then try adding the domain to a WP.com site.

The problem here is that Calypso was, I need to check in on things now, saying that it set the primary domain properly. HEs also don't seem to have somewhere to easily see the error without searching some specific backend logs.

jartes commented 1 month ago

This is something that is affecting the domain forwarding feature as well.

The steps to reproduce are the same as p9F6qB-7QU-p2#comment-44342 but instead of setting the domain as primary, you'll need to forward the domain to another URL.

I encountered this when helping @ebinnion on 8683223-zd-a8c.

I know it's not a common support request, but can we reconsider and take a look at it? Thanks!

github-actions[bot] commented 1 month ago

Support References

This comment is automatically generated. Please do not edit it.