search

Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.42k stars 1.99k forks source link

Audit usage of Atomic_Plan_Manager::BUSINESS_PLAN_SLUG and ::ECOMMERCE_PLAN_SLUG #60145

Open obenland opened 2 years ago

obenland commented 2 years ago

There is at least two places that makes assumptions about the else condition.

  1. WPCOMSH_CLI_ECOMMERCE_PLAN_PLUGINS which disables deacrtivation of woocommerce. We'll likely need to move this into WPCOMSH_CLI_DONT_DEACTIVATE_PLUGINS

  2. In the else of a ecomm check: 'The Business plan for %3$s expires in %2$s. Renew your plan to retain Business plan features such as custom plugins and themes, SFTP, and phpMyAdmin access.', Likely some cross over with Woonification

obenland commented 2 years ago

@lsl Is there still work to be done here?

lsl commented 2 years ago

This issue represents the work required to figure that out :smile: