Open vindl opened 2 years ago
adding https://github.com/Automattic/wp-calypso/issues/57997 to the list above.
Regarding the fse-eligible
sticker... there is also some related code to remove in both Calypso and wpcom:
I think it's just this one line, sending the enable_fse
parameter
I believe the whole wp-content/mu-plugins/full-site-editing/class-site-editor.php
file can be removed, as we don't need to enroll new sites any longer. Additionally the helper function wpcom_enroll_in_fse()
can be removed, as that's the only place it's used.
The purpose of this issue is to track some placeholder code that we can clean up after FSE is fully rolled out:
is_core_fse_active
checks and replace usages withis_fse_theme
. Follow up to this PR: https://github.com/Automattic/wp-calypso/pull/61040 - (WPCOM PR for removal: D83298-code)fse-eligible
sticker toggle in the Blog RC. (WPCOM PR for removal: D83050-code)is_fse_eligible
related conditionals in calypso, default to fse eligible behavior. (Calpyso PR for removal: https://github.com/Automattic/wp-calypso/pull/64710)is_fse_eligible
field from block editor endpoint, andwpcom_is_fse_eligible
function and its remaining uses.calypso_fse_enrolled
event and stop recording it. (Calypso PR for removal: https://github.com/Automattic/wp-calypso/pull/64710)calypso_fse_beta_opt_in
event.non-universal-fse
tag and usages.After the plan to migrate legacy FSE sites to Core FSE is executed (see pbAok1-27H-p2), there is a lot of code that we can remove as it will no longer be used by any sites on WP.com. It's important to do this, as leaving this code in place creates confusion because it refers to "FSE" but not the features and functionality that most people now think of when seeing FSE.
This list likely incomplete, but here's a start to what we should remove/change
\A8C\MU\Full_Site_Editing\Full_Site_Editing
file and class from wpcomA8C\MU\Full_Site_Editing
from helper functions (enroll_in_fse
andis_fse_eligible
)