Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.4k stars 1.98k forks source link

FSE: clean up unused code after the rollout #61107

Open vindl opened 2 years ago

vindl commented 2 years ago

The purpose of this issue is to track some placeholder code that we can clean up after FSE is fully rolled out:

After the plan to migrate legacy FSE sites to Core FSE is executed (see pbAok1-27H-p2), there is a lot of code that we can remove as it will no longer be used by any sites on WP.com. It's important to do this, as leaving this code in place creates confusion because it refers to "FSE" but not the features and functionality that most people now think of when seeing FSE.

This list likely incomplete, but here's a start to what we should remove/change

Addison-Stavlo commented 2 years ago

adding https://github.com/Automattic/wp-calypso/issues/57997 to the list above.

creativecoder commented 2 years ago

Regarding the fse-eligible sticker... there is also some related code to remove in both Calypso and wpcom:

Calypso

I think it's just this one line, sending the enable_fse parameter

https://github.com/Automattic/wp-calypso/blob/e4a70f5af0d7c5d1792403c3691585d587f03c5a/client/lib/signup/step-actions/index.js#L179

wpcom

I believe the whole wp-content/mu-plugins/full-site-editing/class-site-editor.php file can be removed, as we don't need to enroll new sites any longer. Additionally the helper function wpcom_enroll_in_fse() can be removed, as that's the only place it's used.