Open kwight opened 2 years ago
Addison-Stavlo
commented
2 years ago I think we may be soon getting rid of these footer credits in place of banners? cc @autumnfjeld regarding this and the timeline for implementing that change.
the template switcher probably isn't going anywhere anytime soon though!
agrullon95
commented
2 years ago Discussion I started with i18n Team Global: p1665669219548739-slack-C02AED43D
Translations were properly displayed on Atomic sites, but they were not working for Simple sites.
@yuliyan figured out that _load_textdomain_just_in_time() is not able to load the translation files from the appropriate directory on Simple sites for blockbase, blockbase-premium, and their child themes. load_theme_textdomain() is required to load the translation strings.
Post on Themes P2 to raise visibility: pNEWy-fzv-p2 Themes team pull request with potential fix: https://github.com/Automattic/themes/pull/6484
pbking
commented
2 years ago #6484 has been deployed. This may have addressed some of the issues noted above.
agrullon95
commented
2 years ago Thanks for the update @pbking. The changes in #6484 have fixed the translation issue for some of themes in the PR (blank canvas, blockbase) , but I'm still having translation issues for theme ssuch included such as vivre and disco.
autumnfjeld
commented
1 year ago Sorry about the delayed answer @Addison-Stavlo
I think we may be soon getting rid of these footer credits in place of banners? cc @autumnfjeld regarding this and the timeline for implementing that change.
We already have banners in place and I think the footer credits might be theme dependent. In block themes the user can just delete the block, so it isn't enforced like with classic themes.
I noticed today that when using a language other than English (FR in this case), the site editor's template switcher and the WP.com footer text are not translated (the footer text is properly translated on the front-end, however).