Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.42k stars 1.99k forks source link

FSE: Remove "Nav Menus" panel from Customizer #62501

Open jffng opened 2 years ago

jffng commented 2 years ago

What

For FSE enabled themes, remove the Menus panel from the Customizer:

From To
Screen Shot 2022-04-04 at 3 56 27 PM Screen Shot 2022-04-04 at 3 56 07 PM

Why

https://github.com/Automattic/wp-calypso/pull/60692 already removed Appearance > Menus for these themes. I think it would be more consistent to also remove this Menus editing view from the Customizer so that the Site Editor is the single source of truth for menus, otherwise there is the possibility that they become out of sync. More context:

https://github.com/Automattic/themes/issues/5628

How

No response

jffng commented 2 years ago

cc @Addison-Stavlo in case you have thoughts here :)

liviopv commented 1 year ago

@jffng I'm working on a P2 post that will touch on this, and I'm wondering Customizer > Menus load for some themes and not on others.

If I install a WordPress.com Premium theme like Kerr, I get access to menus from the customizer, but when I select TT3, there's no path to edit menus in the customizer, even if the site has classic themes previously saved.

I'm unfamiliar with the code, but I think this could be theme-dependent?

jffng commented 1 year ago

@liviopv yes it's indeed theme dependent — if the site is a block theme, menus should only editable via the site editor.

That said, I think this issue can now be closed.

liviopv commented 1 year ago

Reopening as this is still a pain point for Happiness

cuemarie commented 1 year ago

📌 ACTIONS

dsas commented 1 year ago

Will be resolved by https://github.com/Automattic/wp-calypso/issues/71130