search

Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.41k stars 1.98k forks source link

FSE :: Navigation Block :: Duplicate Menus. #62521

Closed mdtanjid0 closed 1 year ago

mdtanjid0 commented 2 years ago

Quick summary

If we create a classic menu from the customizer and then use it via the Navigation block with FSE, the menu name gets duplicated and increments with every click.

I have created a short video to explain it better:

https://user-images.githubusercontent.com/54123436/161786246-c6986c48-36dc-4f43-974b-3fd8a0e7c0aa.mp4

Steps to reproduce

  1. Activate the Blank Canvas theme.
  2. Create a classic menu from the customizer.
  3. Assign some items there, and save the changes.
  4. Go to Appearance -> Editor.
  5. Take the Navigation block.
  6. And Select the menu.
  7. Take a look at the top. It increments with every click.

What you expected to happen

It shouldn't increment or duplicate the menu. It should show one no matter how many times we select it.

What actually happened

It increments with every click.

Context

4917044-zen

Simple, Atomic or both?

Simple, Atomic

Theme-specific issue?

No response

Browser, operating system and other notes

No response

Reproducibility

Consistent

Severity

Some (< 50%)

Available workarounds?

Yes, difficult to implement

Workaround details

I have selected "Difficult to implement" because now it's not user-friendly, and sometimes users get confused.

There is no workaround to fix the issue, but we can still use that.

Robertght commented 2 years ago

I tested this on a self-hosted site with Twenty Twenty-Two and I can confirm this happens there too. Gutenberg version 13.0.

I believe this is the equivalent for this issue: https://github.com/WordPress/gutenberg/issues/36307

cc @Automattic/cylon, @zachspears

ClassicRKR27 commented 2 years ago

Suggested to the user that they edit their menus directly within the Site Editor instead of the Customizer.

github-actions[bot] commented 2 years ago

Support References

This comment is automatically generated. Please do not edit it.

KirkwallDay commented 2 years ago
mrfoxtalbot commented 1 year ago

This is solved (or at least greatly alleviated) using Version 14.2.0 of the editor. Please see https://github.com/WordPress/gutenberg/issues/36307 & https://github.com/WordPress/gutenberg/issues/39489

I am marking this as solved.