Footer Credit: `Hide (Business Plan Required)` entry should be updated

zdenys commented 2 years ago

Quick summary

At My Site → Appearance → Customize → Site Identity → Footer Credit, the current entry Hide (Business Plan Required) should be updated to something neutral like Hide (Plan Upgrade Required) (especially if we later introduce a Flexible Plan in addition to the current Pro Plan).

Steps to reproduce

Navigate to My Site → Appearance → Customize → Site Identity → Footer Credit
See the list of entries in the drop-down list Footer Credit

What you expected to happen

See something neutral like Hide (Plan Upgrade Required)

What actually happened

Hide (Business Plan Required) is shown even though Business Plan is now a legacy one.

Context

No response

Simple, Atomic or both?

Simple

Theme-specific issue?

No

Browser, operating system and other notes

macOS Monterrey 12.3 with Google Chrome Version 100.0.4896.75 (Official Build) (x86_64)

Reproducibility

Consistent

Severity

Most (> 50%)

Available workarounds?

No but the platform is still usable

Workaround details

No response

sophiegyo commented 2 years ago

southp commented 2 years ago

The fix is ready for review at code-D81007

gmovr commented 2 years ago

This is now deployed cc: @ciprianimike

zdenys commented 2 years ago

Thank you for working on this. I can see it in production on my test site. Closing 🎉

sophiegyo commented 2 years ago

Quick question - are we going to need to get this adjusted again when the starter plan is rolled out? Because it doesn't look like the starter plan will include it and that will inevitably result in people with the starter plan going "but I have a plan, why does this not apply for me?"

Reference: p7DVsv-etM-p2

zdenys commented 2 years ago

Good point, @sophiegyo! It's very timely of course now that we have a new Starter plan. To address it, we would need to either find one good phrasing that is plan agnostic (I cannot think of one just yet) OR settle with some conditional label there (if plan is X display label Y) as we have a mix of legacy plans and new plans now.

On legacy Free, Blogger, Personal, Premium Plans we can show the old label Hide (Business Plan Required)
On new Free, Starter Plans we can show Hide (Pro Plan Required)

I'll reopen the issue at this point as it requires a new solution.

philnick206 commented 2 years ago

In doing some testing of the footer credit on the starter I noticed that the wording "Upgrade to Business" is still being used in the label underneath as shown here:

CleanShot 2022-05-25 at 14 44 00@2x

gmovr commented 2 years ago

@ciprianimike Could you take a look at this "Upgrade to business" CTA here?

ciprianimike commented 2 years ago

@gmovr fix for the CTA in the diff https://github.com/Automattic/wp-calypso/issues/62757

jamiepalatnik commented 2 years ago

📌 HOUSEKEEPING

Labels ✅
Priority ✅
Replicable on Core - N/A

📌 SCRUBBING

Tested on Simple ✅

📌 FINDINGS/SCREENSHOTS/VIDEO

From this comment it sounds like there may be a fix released soon, but when I check on my test simple site I still see the Upgrade to Business CTA, so marking as Triaged for now.

Screenshot:

📌 ACTIONS

Marked as Triaged for Quality Squad review

inaikem commented 2 years ago

@ciprianimike, per the suggestions in the linked diff, we'd love to see this messaging (or the underlying triggers) to be more plan agnostic. Is there a way we can support you to do this via Happiness?

mrfoxtalbot commented 2 weeks ago

Automattic / wp-calypso