Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.42k stars 1.99k forks source link

i18n Verticals List API & UI #63076

Closed autumnfjeld closed 2 years ago

autumnfjeld commented 2 years ago

Description

Note: We will ship MVP to English only users, but soon after ship to all languages.

image

The foundations of the v13n UI & API are now in place. See CfT pbxlJb-1Fl-p2 for background) and now we can begin work on these features for i18n. This could get complicated! šŸ˜† We may want to break the work down by language groups as there are likely to be unique issues with symbol languages, non-latin languages, and RTL languages. Luckily Ganon has some valueable resources: people that are native in some of these languages!! šŸ„³ Still, we will rely heavily on Team Global for help with this work.

Back in March Yuliyan Slavchev reached out to ask if we needed help p1648039123055139-slack-CRWCHQGUB. This is the best place to start with this effort.

This issue is likely to be as much about coordination with Team Global as actual dev work.

The verticals list to be translated

i18n Resources & Help

Acceptance criteria

Dev Task List

Please update this as the work is defined.

Related

autumnfjeld commented 2 years ago

@miksansegundo I added some additional help points in the description above.

As we discussed in Ganon sync today, one way you can start your "i18n journey" is to try the v13n flow in a non-english language. You should see that all the standard screen text should already be translated, as @arthur791004 showed in this screenshot:

Image

If you find any standard screen text (by standard I mean not the v13n drop down list) that isn't translated, you can open an issue and track down why it isn't translated. The first step in searching for strings that have failed translation is to look here: mc tool /linguine/review/ or via https://translate.wordpress.com/developer/griffithchen - for this you need to know who did the PR that had the string to be translated, in this example @taipeicoder šŸ˜„

roo2 commented 2 years ago

One things related to this, currently the text used by the block patterns is not scheduled for translation. I'm not sure if this is something that we need to be translated or if it's better to wait for after the MVP when we look at implementing verticalizing text content?

Screen Shot 2022-06-02 at 2 01 02 pm

Also the title set on the preview does not appear to be translated. I believe it makes sense to look into getting the titles translated now, as they are not as likely to change.

cc @autumnfjeld @miksansegundo @that-mike-bal

roo2 commented 2 years ago

I fixed the site title issue. It is now translated if available šŸŽ‰ .

There appear to be further issues with translation of the previews.

Screen Shot 2022-06-03 at 12 00 12 pm
miksansegundo commented 2 years ago

We still have strings pending for translation:

Screen Shot 2565-06-20 at 12 44 48 Screen Shot 2565-06-20 at 12 42 32

I have checked mc tool /linguine/review/ to try to find other pending translations related to the verticalization but I couldn't find a way to filter them in Linguine. @roo2 Maybe you know how to find them and check the status? All the posts in dotcomverticalposts.wordpress.com have to be translated.

miksansegundo commented 2 years ago

We can keep track of the status of the translations for each post in dotcomverticalposts.wordpress.com in the MC patterns-toolkit/block-patterns/index.php?site=dotcomverticalposts.wordpress.com. For now, we have about 50% translated.

miksansegundo commented 2 years ago

We have landed the issue Pattern i18n - Translate dynamic post content in the query blocks and an existing LTR issue has been solved too in 465-gh-Automattic/i18n-issues.

We still have pending the following issues:

autumnfjeld commented 2 years ago

@miksansegundo LEt's close this issue, it is complete and any remaining items should have new issues, which i see in 84-gh-Automattic/ganon-issues

It seems like this isn't an open issue, correct?

Missing vertical suggestion translations for some locales intentionally preserved in English Are these strings intentionally left in English, meaning no translation needed , so no further work regarding these particular strings?

miksansegundo commented 2 years ago

It seems like this isn't an open issue, correct?

Correct. That is not an open issue but something we could consider improving because our use case for the verticals might be an exception. The convo is here.