Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.43k stars 1.99k forks source link

Embed block: Silently fails and converts to paragraph block on simple sites. #64918

Open arinoch opened 2 years ago

arinoch commented 2 years ago

Quick summary

A URL that can't be embedded will not throw an error, but silently convert to a paragraph block. This deviates from core behaviour.

Steps to reproduce

  1. Create a post, page, or portfolio project on a simple site.
  2. Try to embed a URL that won't embed. The user tried with this URL, and so did I. https://www.washingtonpost.com/brand-studio/wp/2021/11/05/celebrate-christmas-at-the-regions-best-holiday-destination/

What you expected to happen

WordPress should throw an error that it couldn't be embedded and give you either a retry option or to convert it to a link, as it does for atomic sites and in core.

What actually happened

The embed fails silently and is automatically converted to a link. The user is not told what happened or why.

Context

Reported in 35886495-hc, followed up in 5321519-zd-woothemes, tested by HE in chat and myself in ticket.

Simple, Atomic or both?

Simple

Theme-specific issue?

No response

Browser, operating system and other notes

No response

Reproducibility

Consistent

Severity

Some (< 50%)

Available workarounds?

No but the platform is still usable

Workaround details

Users will likely choose to convert it to a link regardless, but this became an interaction due to the lack of feedback. Converting it to a link, if silently, is better than stripping the failed embed.

Greatdane commented 2 years ago

📌 SCRUBBING

📌 FINDINGS/SCREENSHOTS/VIDEO

📌 ACTIONS

desnum commented 2 years ago

I ran into a case with this in 35990166-hc:

Screen Shot 2022-07-05 at 4 40 41 PM

The URL for the embed fails in this particular page, but it works on others. And this particular page allows embeds for other URLs, just not this one.

The current workaround is to use the button block instead, for now.

connorhipps commented 2 years ago

It looks as though this issue was reported on another post as updated here: 5351542-zd-woothemes

DavidSaladu commented 2 years ago
github-actions[bot] commented 2 years ago

Support References

This comment is automatically generated. Please do not edit it.

kspilarski commented 1 year ago

Same case in 6182390-zen.

suyogyashukla commented 1 year ago

The user in 6182390-zen reached out again asking for an update here - @jordesign are you able to help move this towards a fix?