Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.41k stars 1.98k forks source link

Non-FSE themes don't support border radius edits in the Image Block #65223

Open pauljacobson opened 2 years ago

pauljacobson commented 2 years ago

Quick summary

A user in 5348907-zen asked for help accessing the border radius feature available in the Image Block. The user's site is using the Intergalactic 2 theme. The option is not available when this theme is active.

The option is, however, available on FSE-enabled themes.

Steps to reproduce

  1. Enable Intergalactic 2 theme on a site (Independent Publisher 2 is another option I tested).
  2. Add an Image Block to a post or page.
  3. Note that there is no option to adjust border radius.
  4. Switch to a FSE-enabled theme.
  5. Note that the border radius feature is available on this theme.

What you expected to happen

I expected to see a border radius feature consistently across available themes in our themes showcase, like this:

Capture_2022-07-05 at 10 28 40

What actually happened

Instead, the feature does not seem to be available for non-FSE themes:

Capture_2022-07-05 at 10 29 47

Context

The user reported this in 5348907-zen

I tested this on a test site on the WordPress.com Personal Plan. I reproduced the issue using the following themes:

I was able to access the feature using FSE-enabled themes.

Simple, Atomic or both?

Simple, Atomic

Theme-specific issue?

Yes, this seems to affect non-FSE themes.

Browser, operating system and other notes

This does not appear to be relevant.

Reproducibility

Consistent

Severity

All

Available workarounds?

No but the platform is still usable

Workaround details

The workaround here would be Custom CSS.

cuemarie commented 2 years ago

šŸ“Œ SCRUBBING

šŸ“Œ FINDINGS/SCREENSHOTS/VIDEO

šŸ“Œ ACTIONS

jerrysarcastic commented 2 years ago

Also reported in https://wordpress.com/forums/topic/border-and-radius-options-not-showing

This site owner is using the Saga theme, and reported the same issue where border size/radius options do not appear for the image block. Was able to replicate on a test site, and can confirm that when Saga is the active theme there is no option, even if borders were set previous to the theme switch.

Screen Shot 2022-09-14 at 3 11 56 PM

Also noting here that in the time since this issue was filed, we do document for site owners that there is a border radius option for this block: https://wordpress.com/support/wordpress-editor/blocks/image-block/#border-and-radius

github-actions[bot] commented 2 years ago

Support References

This comment is automatically generated. Please do not edit it.