Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.41k stars 1.98k forks source link

CSS issues in RTL for the onboarding flow #65521

Closed miksansegundo closed 2 years ago

miksansegundo commented 2 years ago

Steps to reproduce

  1. Set language to Arabic or Hebrew
  2. Create new site at /start
  3. Select domain and free plan
  4. Select "Build" from the Where to start page.
  5. See issues

What I expected

Goals screen image

Suggestion list image

Site Name and Description image

After selecting the “Write and Publish” option image

After selecting the “Sell online” option image

Design Picker image

Related 437-gh-Automattic/i18n-issues

miksansegundo commented 2 years ago

Most of the issues were not reproducible in the local dev environment because the HTML links to the right CSS files rtl.css on the onboarding screens but this is not the case in the rest of the environments. Specifically, in all the screens after the domain selection, the HTML links to the CSS files min.css instead of rtl.css. For instance:

The CSS file path issue is affecting all the environments except for the Calypso live containers. See how the issues are not reproducible on the Calypso live container for issue #65550.

Screen Shot 2565-07-13 at 20 24 12

@Automattic/ganon why do you think this issue happens on production, staging, horizon, and wpcalypso environments but not on the local dev environment or the Calypso live containers? It could be something related to the PHP logic that adds the links. I have not been able to find where is that logic so far. Or maybe it is related to the plugins used in the sass config for webpack.

The only issue reproducible in the local dev environment was https://github.com/Automattic/wp-calypso/pull/65550 and we solved it by defining a specific CSS for RTL as described in the CSS/SASS coding guidelines for RTL CSS.

Other issues like the WordPress logo position, have been solved in 437-gh-Automattic/i18n-issues and can be tested on wpcalypso.wordpress.com.

arthur791004 commented 2 years ago

Discussion: p1657722599282629-slack-CRWCHQGUB

miksansegundo commented 2 years ago

I'm closing this because the remaining issues have been solved separately or we have created new issues.