Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.43k stars 1.99k forks source link

[Block] Buttons - Nested buttons have different block settings and styles than un-nested buttons #66426

Open nicolynramos opened 2 years ago

nicolynramos commented 2 years ago

Quick summary

When you add the MailChimp block to a page and style the button to be filled with a custom background color, the button will show the correct background color but keep the theme's default button outline.

Steps to reproduce

  1. Open a page to edit
  2. Insert the MailChimp block
  3. Select the MailChimp form button
  4. Set the button to the Fill style
  5. Add a custom background color
  6. Publish/save changes and view live page

What you expected to happen

You should see the button has the custom background color you set with no outline. This should match the behavior of other buttons on the site.

What actually happened

The button shows the custom background color with the theme's default outline settings. The way the button's style behaves in the MailChimp block is vastly different across themes.

Context

This user reported that some of their buttons have outlines while others do not: zen-5466670 I also tested on a test site I have and was able to reproduce error, not only on the Blank Canvas theme, but several others as well.

Platform (Simple, Atomic, or both?)

Simple

Theme-specific issue?

Blank Canvas was originally reported but many others affected.

Here's a video of me flipping through a few to test, starting with Blank Canvas:

https://user-images.githubusercontent.com/71851343/183775145-81366db9-4f20-476b-a5c6-c6fbd64a23a1.mp4

Browser, operating system and other notes

No response

Reproducibility

Consistent

Severity

Some (< 50%)

Available workarounds?

No response

Workaround details

For sites on Free or Personal plans, no workaround available. Custom CSS could be used for site plans that allow it.

cuemarie commented 2 years ago

📌 SCRUBBING

📌 FINDINGS/SCREENSHOTS/VIDEO

To test this, I set up a post with many different buttons inside the Mailchimp block, Form blocks, and on their own. Then I switched around themes to compare those buttons.

Simple, Theme: Blank Canvas

https://user-images.githubusercontent.com/27249804/184191950-f7cf0f86-e9aa-4615-aaae-d467d73a9089.mov

Markup on 2022-08-11 at 10:10:36

Simple, Theme: Blask Markup on 2022-08-11 at 10:12:08

Simple, Theme: Twenty Sixteen - (border colors match, but default border radius issue now presents Markup on 2022-08-11 at 10:14:01

Simple, Theme: Twenty Eleven

Markup on 2022-08-11 at 10:17:45

📌 ACTIONS

cuemarie commented 2 years ago

Some other issues that may be related to this:

And a pull request in the works here that could be relevant as well: