Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.41k stars 1.98k forks source link

New email notification template: Image caption formatting is broken. #66739

Closed inaikem closed 1 year ago

inaikem commented 2 years ago

Quick summary

Image captions in the new email template appear larger than paragraph text and there's no linebreak/spacing after them.

z2dndM.png

The screenshot above was from a notification sent from a site using the TwentyTwenty theme.

Steps to reproduce

  1. Create a post with images and captions.
  2. Publish the post
  3. View the notification email.

What you expected to happen

I expected the captions to be the same size, smaller, or formatted differently from normal paragraph text.

What actually happened

Image captions in the new email template appear larger than paragraph text and there's no linebreak/spacing after them.

Context

Chat: 35641737-hc Ticket: 5490339-zd-woothemes

Platform (Simple, Atomic, or both?)

Simple

Theme-specific issue?

Unknown

Browser, operating system and other notes

No response

Reproducibility

No response

Severity

No response

Available workarounds?

No response

Workaround details

No response

github-actions[bot] commented 2 years ago

Support References

This comment is automatically generated. Please do not edit it.

Robertght commented 2 years ago

📌 HOUSEKEEPING

📌 SCRUBBING

📌 FINDINGS/SCREENSHOTS/VIDEO

📌 ACTIONS

📌 Message to Author

inaikem commented 2 years ago

That's pretty much all I have but I'll ping them for more details on their email client to see if that helps 🙏

inaikem commented 2 years ago

I've reopened the interaction above asking for further details

i11za commented 2 years ago

@Robertght @inaikem user has replied in 5490339-zd-woothemes that they had one post arrive fine in the email, but 2-3 ones prior to that did not, and shared inline copies of the emails. Perhaps it was a temp issue if the latest email arrived fine?

I've acknowledged receipt, and let them know we'll let them know once there's an update. Haven't closed the ticket yet, placing on 72 hour hold.

In hindsight I'm now wondering if we should ask them to send emails as attachments so we can see full email/headers/etc., as well as ask for browser/OS information? Could this be a browser issue?

Also, flagging as something that caught my attention, most likely unrelated: I haven't tested this, but could it be that the Amazon links are somehow breaking the formatting? In the email they shared these seem to be updated from www.amazon.pl/.... to nam12.safelinks.protection.outlook.com/... -

inaikem commented 2 years ago

Perhaps it was a temp issue if the latest email arrived fine?

This may well have been the case. I've sent over a quick reply asking them to let us know if they experience the issue again.

In hindsight I'm now wondering if we should ask them to send emails as attachments so we can see full email/headers/etc., as well as ask for browser/OS information? Could this be a browser issue?

We could (and I just did in my reply 😉). We can see the original forward using the "view original email" option under the envelope icon at the top right of each reply in ZD to view the mail. Here's a screenshot of the first example:

eN9qXh.png

inaikem commented 2 years ago

I'm leaving this in the "Needs HE/Author reply" queue for now but please feel free to close this out if they don't reply over the next 1-2 weeks. We can always reopen and retest if needed 🙏

cuemarie commented 2 years ago

User has replied with screenshots of their new post email, as well as a new post email from a separate blog they follow as well, showing the same issues, shown below. They also anecdotally shared that this experience is shared by others they've been in touch with.

Example Email 1

Screen Shot 2022-09-05 at 8 38 00 AM Screen Shot 2022-09-05 at 8 39 12 AM

Example Email 2 (from a 2nd site)

Screen Shot 2022-09-05 at 8 40 02 AM Screen Shot 2022-09-05 at 8 40 39 AM

@inaikem

Robertght commented 2 years ago

@cuemarie I signed up with Outlook and can confirm this is indeed an issue:

6TWpxp.png

@Automattic/apex can this be adjusted for other email clients as well?

eduardozulian commented 2 years ago

Just to update here that we have another ticket (from the same user) at 5546878-zen. We can use this one to follow up instead.

ivan-ottinger commented 2 years ago

Thank you for sharing the details Robert and Eduardo!

I have added the issue to our maintenance project board.

TimBroddin commented 1 year ago

I've created a patch for this: D93721-code

TimBroddin commented 1 year ago

This fix has been deployed! 🥳