Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.43k stars 1.99k forks source link

Automatic Emails for Requesting Access for Private Sites needs to be reformatted #70787

Open ClassicRKR27 opened 1 year ago

ClassicRKR27 commented 1 year ago

Quick summary

User noticed that through several email clients, there is a : right before the hyperlink that is actually breaking the hyperlink (they mentioned Gmail and Microsoft Office).

Steps to reproduce

Not really sure how to "reproduce" this one, honestly 😅 I would recommend just reviewing the information in the ticket.

What you expected to happen

There should be a space there to ensure that the URL can be clicked on regardless of the email client the user has.

What actually happened

There is no space which breaks the link.

Context

5762818-zd-woothemes

Platform (Simple, Atomic, or both?)

No response

Theme-specific issue?

No response

Browser, operating system and other notes

No response

Reproducibility

None

Severity

None

Available workarounds?

None

Workaround details

No response

github-actions[bot] commented 1 year ago

Support References

This comment is automatically generated. Please do not edit it.

jp-imagines commented 1 year ago

I think this may be a translation/i18n issue, actually. I set one of my simple test sites as Private, visited it from another browser, logged in and clicked the request access link to trigger the email.

The email that came through is formatted properly, with a space before the colon:

Markup on 2022-12-07 at 12:43:05

The ticket user's account/site language are set to Dutch. I'm unsure if other languages are affected, but that definitely seems to be where the issue lies.

cuemarie commented 1 year ago

📌 SCRUBBING : RESULT - Replicated / Could Not Replicate / Uncertain

📌 FINDINGS/SCREENSHOTS/VIDEO

Markup on 2022-12-21 at 13:40:42

There is not a space after the : the way that the English language email contains. This didn't break the link for me, but different email clients may handle that link differently.

📌 ACTIONS