[Bug]: opening post/page editor at Atomic fires 404 "intent" API requests

[simison]

Quick summary

I see we request for "intent" in couple places in the editor, added in PRs regarding Seller experience:

https://github.com/Automattic/wp-calypso/pull/61222 https://github.com/Automattic/wp-calypso/pull/61771

On my Atomic site these APIs (/wp-json/wpcom/v2/site-intent) are returning 404 not found.

Furthermore, we request the data twice, while we could request just once and add to data store, and use it from there?

Even furthermore, we request data even if site is old and we're not about to show these welcome/video modals anyway. We should request only if we're about to show them something, not on every editor load.

Steps to reproduce

1. Have an Atomic site, open post/page editor
2. Observe 404ing API requests in Networks tab

What you expected to happen

Requests to work, or no requests done.

What actually happened

404 requests

Browser

No response

Context

No response

Platform (Simple, Atomic, or both?)

Atomic

Other notes

No response

Reproducibility

Consistent

Severity

None

Available workarounds?

None

Workaround details

No response

[daledupreez]

I am going to ping some of the longer-term members of @Automattic/serenity, as this seems related to some work we did earlier this year.

[mreishus]

Good points re:

• Not working on Atomic
• Fetching twice
  • WIP to move the fetch to react-query to prevent this: #71097
• Fetching for old sites

On atomic, the file responsible for fetching is: wp-content/plugins/full-site-editing/wpcom-block-editor-nux/dist/wpcom-block-editor-nux.min.js. It fetches due to calls from the SellerCelebrationModal and the VideoCelebrationModal.

[sixhours]

Confirmed this is still happening.