Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.42k stars 1.99k forks source link

Image Block: Duotone feature/tool affecting caption display #73531

Closed retnonindya closed 1 year ago

retnonindya commented 1 year ago

Quick summary

When an image (Image Block) has Duotone feature active, the caption ( <figcaption> ) is displayed differently. This happens on classic themes (tested so far: Toujours and Twenty Fifteen)

Steps to reproduce

  1. Make sure the website uses a classic theme. e.g. Toujours
  2. Create a post/page
  3. Insert an image using Image Block
  4. Add caption
  5. Insert another image using Image Block
  6. Set duotone filter
  7. OR, set duotone filter, then click "Unset"
  8. Add caption

What you expected to happen

Both images should have the caption displayed in the same way (same font size, same color, same display)

What actually happened

The cause:

<figure class="wp-duotone-unset-1">

... or...

<figure class="wp-duotone-COLOR CODE">

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

Simple, Atomic

Logs or notes

Workaround:

cuemarie commented 1 year ago

πŸ“Œ SCRUBBING : RESULT - Replicated / Could Not Replicate / Uncertain

πŸ“Œ FINDINGS/SCREENSHOTS/VIDEO

Simple Example

https://user-images.githubusercontent.com/27249804/227043718-133ab63b-3d34-49a3-b9f1-8980371703a1.mov

πŸ“Œ ACTIONS