Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.42k stars 1.99k forks source link

Page Preview feature not working correctly on Simple sites #73708

Open kingsleyinfo opened 1 year ago

kingsleyinfo commented 1 year ago

IMPORTANT: collect browser and setup info

If you run into another case of this issue, please collect and report:

Quick summary

The page preview feature is not working correctly on simple sites. A user had this issue and I was unable to replicate the issue initially.

Still on the chat, they swapped browsers and the issue was still there, so I tested on their site and can now see the issue.

I was also able to replicate this on my simple site with the Premium plan. Atomic sites work okay

Steps to reproduce

On a simple site with the Premium plan, try editing a post. Like adding a text. Click on Preview on another tab. Changes will not appear.

2023-02-23 09 11 04

From my perspective, it would appear like a caching issue, as giving that same page a few minutes and previewing it again would show the changes.

2023-02-23 09 14 19

What you expected to happen

The page preview should work immediately you preview the content

What actually happened

The edits do not show on the page after preview, except you wait a while and refresh the page or preview again after some time, which is not ideal.

Impact

All

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

Simple

Logs or notes

Tested on Chrome The user tested on Hermes which is retired, but I replicated it using Edin which is also a classic theme and Bitacora which is a theme with FSE support.

40193220-hc

cuemarie commented 1 year ago

📌 SCRUBBING : RESULT - Replicated / Could Not Replicate / Uncertain

📌 FINDINGS/SCREENSHOTS/VIDEO

Simple Example

https://user-images.githubusercontent.com/27249804/227056845-974c9356-8fbc-4783-8897-2da318b2bbb3.mov

AT Example for comparison

https://user-images.githubusercontent.com/27249804/227057643-6d9d7dcb-eb55-4d56-9b98-233d29f38030.mov

📌 ACTIONS

zoonini commented 10 months ago

I see this now happening on Atomic sites as well. Replicated on a test site, and reported for an Atomic site here:

7380599-zd-a8c

github-actions[bot] commented 10 months ago

Support References

This comment is automatically generated. Please do not edit it.

kathrynwp commented 10 months ago

Apologies, the previous comment should have been written from this account:

I see this now happening on Atomic sites as well. Replicated on a test site, and reported for an Atomic site here:

7380599-zd-a8c

liviopv commented 10 months ago

I tested this on a simple site using TT4 after being pinged on p1701880468778519-slack-C0160HSMDQV but I couldn't reproduce. Publishing the page doesn't change how the preview works for me - changes show up in preview immediately after.

https://github.com/Automattic/wp-calypso/assets/14153300/4cce6fc9-8d8c-4367-b323-2cb7d75428d4

Same thing on my Atomic site with TT4.

https://github.com/Automattic/wp-calypso/assets/14153300/35cdb884-8502-4ff5-93ee-f940ab770a37

Both tests were done in Chrome 120 on Mac Sonoma. Considering preview directly interacts with caching and privacy settings, I wonder if there's a browser component here.

Since it's been quite long between the first report and the most recent ones, it could be that the issue has been fixed and been broken again recently, but I haven't found any relevant PR in the last few GB releases that would explain this. I think we might be missing a key piece of info to be able to escalate this, if we believe it's widespread (I personally don't think it is).

@kathrynwp @jp-imagines can you collect browser info and any other setup info that might shine a light on what's happening.

kathrynwp commented 10 months ago

Hi @liviopv - thanks for testing! Here's a screencast that shows an example of what I'm seeing.

Theme: Byrne Atomic site - https://kpsftptesting.wpcomstaging.com/ Firefox 120.0.1

https://github.com/Automattic/wp-calypso/assets/7662449/f8a7ee41-ac36-4c6f-9c1a-713b926ffe94