search

Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.4k stars 1.98k forks source link

Tools - Marketing - Traffic Tab: Sitemap section displays http instead of https #73876

Open ccwalburn opened 1 year ago

ccwalburn commented 1 year ago

Quick summary

We recommend using the http version of the sitemap on the Tools > Marketing > Traffic tab but it should be the https version.

sitemap

Steps to reproduce

  1. Go to Tools > Marketing > Traffic
  2. Scroll down to Sitemaps section

What you expected to happen

I expected the sitemap URL to use https

What actually happened

The sitemap URL used http

Impact

All

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

No response

Logs or notes

40847219-hc p1677523591004309-slack-C03TY6J1A

danielbachhuber commented 1 year ago

The code simply pulls site.URL:

https://github.com/Automattic/wp-calypso/blob/86511930fb52e4bc3922ddb2a61122e3d6f51cdc/client/my-sites/site-settings/sitemaps.jsx#L106-L109

The underlying stored value was http://charleyross.com, so I updated it to https://charleyross.com with wp shell. I'm not sure how it got in the incorrect state.

It'll take a little bit for caches to clear, so I'll verify everything is working in a support session later.

danielbachhuber commented 1 year ago

Didn't quite work. More debugging in this thread: p1677613762588429-slack-C03N25JPCE4

danielbachhuber commented 1 year ago

As it turns out, this is quite a rabbit hole (see Slack conversation). We don't currently expose Simple sites with mapped domains as https because we don't have a source of truth on whether their SSL certificate is valid.

We'll need to shape this before we can produce a solution: https://github.com/Automattic/dotcom-forge/issues/1955

Moving this issue to Hold in our backlog.

kavyagokul commented 1 year ago

📌 SCRUBBING : RESULT

📌 ACTIONS