Open masperber opened 1 year ago
📌 SCRUBBING : RESULT
📌 FINDINGS/SCREENSHOTS/VIDEO
Sensei Pro (WC Paid Courses) already includes all the blocks included in the Sensei Blocks plugin. You don't need Sensei Blocks plugin if you already using Sensei Pro (WC Paid Courses) plugin.
📌 ACTIONS
📌 Message to Author
Reopening this bug as it is still occurring. The issue is with "Sensei Pro" not "Sensei Pro (WC Paid Courses)". Here is a recording showing the process:
This is on a pre-existing site with the Business plan that went Atomic 2019-04-19.
📌 SCRUBBING : RESULT - Replicated / Could Not Replicate / Uncertain
📌 FINDINGS/SCREENSHOTS/VIDEO
Fatal error: Cannot declare class Sensei_Pro_Setup\Setup_Context, because the name is already in use in /wordpress/plugins/sensei-pro/1.13.0/modules/sensei-pro-setup/class-setup-context.php on line 14
Deactivating either Sensei Interactive Blocks or Sensei Pro removes the critical error warning, pointing to that combination as the conflict.
📌 ACTIONS
📌 Message to Devs
sensei-interactive-blocks
is a Marketplace plugin. Thanks for taking a look!Just pinged the sensei-on-dotcom
team in Slack.
I have mentioned the issue in #sensei-janitorial
slack channel. Hopefully they will be able to look at this soon.
I've checked this a bit and it looks like the expected behavior here is if there is more than one of the plugins among Sensei Pro (WC Paid Courses), Sensei Pro, and Sensei Interactive Blocks are installed, only one of them should be enabled at a time.
There is code in place to enforce the aforementioned behavior, that only one is allowed to be activated. But for some reason it's not enforcing it. I've added this issue to our Janitorial board and we'll look into why that's happening.
Thanks!
Hi @donnapep & @Imran92 , I see this is now off the Sensei Janitorial board. Any updates or recommendations regarding the critical error that happens here?
@cuemarie Looks like this was removed in error. I've added it back.
Impact should be "Some (< 50%)". Setting priority to "Low".
Cc : @candy02058912
Quick summary
If Sensei Pro is installed and activated on a site where Sensei Interactive Blocks is installed, the site will crash with a critical error.
Although Sensei Pro includes all of the features of Sensei Interactive Blocks, attempting to install Sensei Pro while Sensei Interactive Blocks is installed shouldn't crash the site with a critical error.
Steps to reproduce
What you expected to happen
A critical error shouldn't occur. A better solution would be to deactivate Sensei Interactive Blocks when Sensei Pro is purchased, prior to install.
What actually happened
The site crashed with a critical error.
Impact
All
Available workarounds?
No but the platform is still usable
Platform (Simple and/or Atomic)
Atomic
Logs or notes
No response