search

Automattic / wp-calypso

The JavaScript and API powered WordPress.com
https://developer.wordpress.com
GNU General Public License v2.0
12.4k stars 1.98k forks source link

Upgrade flow from My Jetpack [Protect stand-alone]: Inconsistent messaging between plugin & cloud #74579

Open jeffgolenski opened 1 year ago

jeffgolenski commented 1 year ago

When the Protect Stand-alone plugin is present and a user upgrades via the CTA within the bottom of the SA UI. Post purchase the SA UI says a scan is underway, yet cloud.jetpack.com says it's been completed. We just need to be consistent between the UI messaging.

Flow visuals + video walkthrough at task 24 p1HpG7-l2l-p2

Image

jwidavid commented 1 year ago
Screen Shot 2023-03-17 at 3 01 43 PM Screen Shot 2023-03-17 at 3 01 32 PM

I'll try to reproduce on Namecheap next since I already have an account there.

jwidavid commented 1 year ago

I got similar results on Namecheap

  1. Created site
  2. Installed SA Protect Plugin
  3. Connected site
  4. Opened cloud.jetpack.com for the site
  5. Upgraded via CTA on SA
  6. Navigated to Scan on cloud

Both SA and cloud show the scan in progress.

jeffgolenski commented 1 year ago

Thanks for testing @jwidavid !

jwidavid commented 1 year ago

What's the best way for me to test on wp-engine? Looks like they don't have a free plan? I'll look into resolving the issue if I can reproduce it.

miguelxpn commented 1 year ago

@jeffgolenski you mentioned in the issue that there was a video walkthrough but I couldn't find it, could you send it over so we can take a look? I've also tried to reproduce and it seems that things are working as intended.

jeffgolenski commented 1 year ago

@miguelxpn Sure thing. I'll ping you in slack with the direct link since the video may show sensitive info.

miguelxpn commented 1 year ago

I found out what happened. Since in the video you first activated the free version we triggered a job that runs the free Protect scan, which is something completely separate from the paid version that uses Jetpack Scan behind the scenes. So once you upgraded it's very likely that the Jetpack Scan first scan finished quickly because the site wasn't big, but the plugin was still waiting on the free Protect Scan.

I'm not really sure on the best way to address this, we can't really have Calypso report anything about the free Protect scan as it's completely different from Jetpack Scan, perhaps we can try to detect this in the code and just stop pooling the free scan status.